Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fix text/calendar response handling from NTP/other origins #23827

Merged
merged 1 commit into from
May 24, 2024

Conversation

kylehickinson
Copy link
Collaborator

This change adjusts the logic for ensuring tab visibility in responses from mime types such as text/calendar that would be handled by loading the URL in SFSafariViewController.

Resolves brave/brave-browser#38548

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This change adjusts the logic for ensuring tab visibility in responses from mime types such as `text/calendar` that would be handled by loading the URL in `SFSafariViewController`.
@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels May 24, 2024
@kylehickinson kylehickinson self-assigned this May 24, 2024
@kylehickinson kylehickinson requested a review from a team as a code owner May 24, 2024 14:35
@soner-yuksel
Copy link
Contributor

@stoletheminerals context is this Pr should not be breaking this change brave/brave-ios#8618

@kylehickinson kylehickinson enabled auto-merge May 24, 2024 15:17
@kylehickinson kylehickinson merged commit 804061d into master May 24, 2024
20 checks passed
@kylehickinson kylehickinson deleted the ios-cal-fix branch May 24, 2024 15:35
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 24, 2024
brave-builds added a commit that referenced this pull request Jun 4, 2024
brave-builds added a commit that referenced this pull request Jun 4, 2024
@kjozwiak
Copy link
Member

kjozwiak commented Jun 5, 2024

Verification PASSED on iPhone 11 running iOS 17.5.1 using the following build(s):

1.68.72 Chromium: 126.0.6478.26 (Official Build) nightly (64-bit)
--- | ---
Revision | d8df78a64942...
OS | iOS

Reproduced the original issue the STR/Cases outlined via brave/brave-browser#38548 (comment) using 1.66.113 as per the following:

RPReplay_Final1717559324.MP4

Using the same STR/Cases mentioned above, verified that you're able to add events into Calendar by loading a ics URL as per the following:

RPReplay_Final1717559881.MP4

kjozwiak pushed a commit that referenced this pull request Jun 5, 2024
kjozwiak pushed a commit that referenced this pull request Jun 5, 2024
…plift to 1.66.x) (#23990)

Uplift of #23827 (squashed) to release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading a URL that would trigger a calendar invite doesn't work on NTP/other websites
5 participants