-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Fix text/calendar
response handling from NTP/other origins
#23827
Conversation
This change adjusts the logic for ensuring tab visibility in responses from mime types such as `text/calendar` that would be handled by loading the URL in `SFSafariViewController`.
@stoletheminerals context is this Pr should not be breaking this change brave/brave-ios#8618 |
Verification PASSED on
Reproduced the original issue the STR/Cases outlined via brave/brave-browser#38548 (comment) using RPReplay_Final1717559324.MP4Using the same STR/Cases mentioned above, verified that you're able to add events into RPReplay_Final1717559881.MP4 |
This change adjusts the logic for ensuring tab visibility in responses from mime types such as
text/calendar
that would be handled by loading the URL inSFSafariViewController
.Resolves brave/brave-browser#38548
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: