Uplift #1909 to 64.x (webui settings) #2223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebUI: Settings & 4 different ways to override
kjozwiak
reviewed
Apr 16, 2019
There was a problem hiding this comment.
Uplift to 0.64.x denied after deliberating with the @brave/uplift-approvers team. Other than ads, we should only be uplifting regression and other bug fixes. This PR has a lot of changes but there's no urgency to skip the nightly channel. Because there's so many changes, we should let this ride the channels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#958
Fix brave/brave-browser#960
Fix brave/brave-browser#955
Address brave/brave-browser#26 (this is more of an umbrella issue)
Fix brave/brave-browser#964
Fix brave/brave-browser#3444
Fix brave/brave-browser#3826