Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Brave styling for (unchanged) Additional settings #964

Closed
rebron opened this issue Sep 4, 2018 · 3 comments · Fixed by brave/brave-core#1909
Closed

use Brave styling for (unchanged) Additional settings #964

rebron opened this issue Sep 4, 2018 · 3 comments · Fixed by brave/brave-core#1909
Assignees
@petemill
Labels
feature/global-settings Settings at browser level independent of shields settings priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.65.x - Release ...

Comments

@rebron
Copy link
Collaborator

rebron commented Sep 4, 2018 •
edited by bsclifton
Loading

Test plan

See #955

Description

For unchanged Additional Settings: Languages, Downloads, Printing, Accessibility, System, Reset Settings; add icons and use Brave styling for typography and buttons.

Design

updated-settings-screen
@rebron rebron added this to the 1.0 milestone Sep 5, 2018
@rebron rebron added the feature/global-settings Settings at browser level independent of shields settings label Sep 5, 2018
@srirambv
Copy link
Contributor

srirambv commented Sep 5, 2018

@rebron Reset settings in spec shows wrong icon. Need to be updated

@rebron
Copy link
Collaborator Author

rebron commented Sep 23, 2018

@srirambv updated, got the right icon in there now.

@bsclifton bsclifton mentioned this issue Oct 12, 2018
Closed
28 tasks
@bbondy bbondy modified the milestones: 1.0, 1.x Backlog Oct 30, 2018
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 15, 2019
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 15, 2019
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@petemill petemill assigned petemill and unassigned bsclifton Feb 12, 2019
@petemill petemill mentioned this issue Mar 12, 2019
Merged
19 tasks
@petemill petemill added this to the 0.65.x - Nightly milestone Apr 15, 2019
@petemill petemill mentioned this issue Apr 15, 2019
Closed
This was referenced May 10, 2019
Closed
Closed
Closed
@srirambv
Copy link
Contributor

srirambv commented May 27, 2019 •
edited by kjozwiak
Loading

Verification passed on

Brave 0.65.107 Chromium: 75.0.3770.38 (Official Build) beta(64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Linux

image

Verification passed on

Brave 0.65.107 Chromium: 75.0.3770.38 (Official Build) beta (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Windows 10 OS Version 1803 (Build 17134.523)

image

Verification PASSED on macOS 10.14.5 x64 using the following build:

Brave 0.65.112 Chromium: 75.0.3770.38 (Official Build) beta(64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Mac OS X

Screen Shot 2019-05-28 at 1 42 39 PM

Screen Shot 2019-05-28 at 1 43 04 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
feature/global-settings Settings at browser level independent of shields settings priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.65.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

WebUI: Settings & 4 different ways to override brave/brave-core
7 participants
@petemill @bbondy @kjozwiak @bsclifton @rebron @srirambv @btlechowski