Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(wallet): migrate to Jupiter API v6 (uplift to 1.62.x) #21504

Merged
merged 3 commits into from
Jan 9, 2024
Merged

chore(wallet): migrate to Jupiter API v6 (uplift to 1.62.x) #21504

merged 3 commits into from
Jan 9, 2024

Conversation

onyb
Copy link
Member

@onyb onyb commented Jan 5, 2024 •
edited by kjozwiak
Loading

Uplift of #21475
Uplift of #21406
Uplift of #21431

Resolves brave/brave-browser#34932
Resolves brave/brave-browser#35091
Resolves brave/brave-browser#34980

#21406 and #21431 make uplift of #21475 easier, otherwise they have no functional changes.

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

onyb added 2 commits January 5, 2024 22:48
@onyb
chore(wallet): refactor swap service interface (#21406)
0641a93
@onyb
chore(wallet): migrate to Jupiter API v6 (#21475)
0710c17 
* chore(wallet): migrate to Jupiter API v6

* add referral account to collect platform fees

* switch to processed preflight commitment for swaps

* review(doug): remove unused dependencies in hook

* add production referral key
@onyb onyb added this to the 1.62.x - Beta milestone Jan 5, 2024
@onyb onyb self-assigned this Jan 5, 2024
@onyb onyb requested a review from a team as a code owner January 5, 2024 17:56
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Jan 5, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Jekyle
Jekyle reviewed Jan 6, 2024
View reviewed changes
Copy link

@Jekyle Jekyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thy

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

kjozwiak
kjozwiak approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.62.x approved 👍 QA has verified the PR on Nightly using 1.63.x as per #21475 (comment).

@kjozwiak kjozwiak merged commit 9b5f1bd into 1.62.x Jan 9, 2024
13 checks passed
@kjozwiak kjozwiak deleted the uplift-pr21475 branch January 9, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jekyle Jekyle Jekyle left review comments

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@onyb onyb

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Milestone
1.62.x - Release
Development

Successfully merging this pull request may close these issues.
5 participants
@onyb @brave-builds @kjozwiak @Jekyle @SergeyZhukovsky