Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SwapService interface to allow cross-chain swaps #34932

Closed
onyb opened this issue Dec 15, 2023 · 0 comments · Fixed by brave/brave-core#21406
Closed

Refactor SwapService interface to allow cross-chain swaps #34932

onyb opened this issue Dec 15, 2023 · 0 comments · Fixed by brave/brave-core#21406

Comments

@onyb
Copy link
Member

onyb commented Dec 15, 2023

We want generic methods in SwapService to query swap/bridge quotes without relying on the underlying provider (0x, Jupiter, etc).

Here's an example of the methods that we can have:

GetQuote(SwapQuoteParams params) =>
      (SwapQuoteUnion? response, SwapErrorUnion? error, string error_string);

  GetTransaction(SwapTransactionParamsUnion params) =>
      (SwapTransactionUnion? response, SwapErrorUnion? error, string error_string);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants