Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Chat: small UI fixes #20716

Merged
merged 1 commit into from
Oct 27, 2023
Merged

AI Chat: small UI fixes #20716

merged 1 commit into from
Oct 27, 2023

Conversation

nullhook
Copy link
Contributor

Resolves brave/brave-browser#33732
Resolves brave/brave-browser#33944
Resolves brave/brave-browser#33943

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@nullhook nullhook requested a review from a team as a code owner October 27, 2023 16:41
@nullhook nullhook requested a review from petemill October 27, 2023 16:42
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 27, 2023
@nullhook nullhook changed the title ai chat small ui fixes AI Chat: small UI fixes Oct 27, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

}

.featureMenu {
height: var(--leo-icon-size);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why setting a fixed height on the menu to just the icon size? This seems strange when it's always going to need to be much taller

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leo-button-menu has an awkward height (1), so centering is off (2). therefore, i have added an explicit height (3)

[1] image

[2] image

[3] image

@nullhook nullhook merged commit d353689 into master Oct 27, 2023
8 checks passed
@nullhook nullhook deleted the ai-chat-ui-bugs branch October 27, 2023 23:29
@github-actions github-actions bot added this to the 1.62.x - Nightly milestone Oct 27, 2023
@stephendonner
Copy link
Contributor

stephendonner commented Oct 28, 2023

Verification PASSED using

Brave | 1.62.8 Chromium: 119.0.6045.59 (Official Build) nightly (64-bit)
-- | --
Revision | 427a9c28d4368975377f8b6b503daee8a83684cd
OS | Windows 10 Version 22H2 (Build 19045.3636)

Shared Steps:

  1. installed 1.62.8
  2. launched Brave using --env-leo=staging --env-ai-chat.bsg=dev --env-ai-chat-premium.bsg=dev --enable-logging=stderr --v=1
  3. purchased Leo Premium on account.bravesoftware.com
  4. clicked on Leo in the sidebar to open Leo
  5. clicked Accept and begin
  6. loaded https://brave.com/leo-roadmap/

Issue 33732 - PASSED

(continued from Shared Steps)

  1. hovered over the 3-dots ellipsis in the upper-right of the Leo pane

Confirmed the tooltip reads Leo settings

issue33732

Issue 33944 - PASSED

Confirmed gray icons by default, with green icons once Premium-enabled

non-Premium - dark-gray icons Premium - green lock icons
image image

Issue 33943 - PASSED

Confirmed the 3-dots ellipsis is now vertically centered

fixed before
image image

brave-builds added a commit that referenced this pull request Oct 30, 2023
brave-builds added a commit that referenced this pull request Oct 30, 2023
kjozwiak pushed a commit that referenced this pull request Oct 31, 2023
kjozwiak pushed a commit that referenced this pull request Oct 31, 2023
mherrmann pushed a commit that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
5 participants