Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cross-origin .onion origins from location.ancestorOrigins #20622

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Oct 20, 2023

Fixes brave/brave-browser#32421
Sec review: https://github.com/brave/reviews/issues/1436

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open http://ixrdj3iwwhkuau5tby5jh3a536a2rdhpbdbu6ldhng43r47kim7a3lid.onion/referrer/onion.html in a Tor window.
  2. Look at the iframe Sub-resources test cases only.
  3. The Same-origin iframes should show:
    • AncestorOrigins (JS): [http://ixrdj3iwwhkuau5tby5jh3a536a2rdhpbdbu6ldhng43r47kim7a3lid.onion] (single iframe)
    • AncestorOrigins (JS): [http://ixrdj3iwwhkuau5tby5jh3a536a2rdhpbdbu6ldhng43r47kim7a3lid.onion][http://ixrdj3iwwhkuau5tby5jh3a536a2rdhpbdbu6ldhng43r47kim7a3lid.onion][http://ixrdj3iwwhkuau5tby5jh3a536a2rdhpbdbu6ldhng43r47kim7a3lid.onion][http://ixrdj3iwwhkuau5tby5jh3a536a2rdhpbdbu6ldhng43r47kim7a3lid.onion] (blue innermost iframe)
      Screenshot from 2023-10-20 14-15-46
  4. The Cross-origin iframes should show:
    • AncestorOrigins (JS): ["null"] (single iframe)
    • AncestorOrigins=[https://fmarier.com]["null"]["null"] (red middle iframe)
    • AncestorOrigins (JS): [https://fmarier.com][https://fmarier.com][http://ixrdj3iwwhkuau5tby5jh3a536a2rdhpbdbu6ldhng43r47kim7a3lid.onion][http://ixrdj3iwwhkuau5tby5jh3a536a2rdhpbdbu6ldhng43r47kim7a3lid.onion] (blue innermost iframe)
      Screenshot from 2023-10-20 14-16-03

@fmarier fmarier self-assigned this Oct 20, 2023
@fmarier fmarier force-pushed the onion-ancestorOrigins-32421 branch from 1d0e7f2 to ce3b141 Compare October 24, 2023 04:49
@fmarier fmarier marked this pull request as ready for review October 24, 2023 04:51
@fmarier fmarier requested review from iefremov and a team as code owners October 24, 2023 04:51
@fmarier fmarier force-pushed the onion-ancestorOrigins-32421 branch 2 times, most recently from 5015a29 to b0815d4 Compare October 24, 2023 20:23
@fmarier

This comment was marked as outdated.

@fmarier fmarier force-pushed the onion-ancestorOrigins-32421 branch from b0815d4 to 9a15f66 Compare November 2, 2023 22:35
@fmarier fmarier removed the request for review from a team November 2, 2023 22:40
@fmarier fmarier force-pushed the onion-ancestorOrigins-32421 branch from 9a15f66 to 2e3cf58 Compare November 3, 2023 21:05
@fmarier fmarier merged commit e94922b into master Nov 3, 2023
@fmarier fmarier deleted the onion-ancestorOrigins-32421 branch November 3, 2023 23:27
@github-actions github-actions bot added the CI/run-network-audit Run network-audit label Nov 3, 2023
@github-actions github-actions bot added this to the 1.62.x - Nightly milestone Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hackerone] Remove onion services from window.location.ancestorOrigins
4 participants