Fixes date for recurring banner #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes date for recurring banner
kjozwiak
approved these changes
Mar 7, 2019
There was a problem hiding this comment.
Uplift to 0.62.x approved after deliberating with @rebron and as per our earlier discussion in the b-c triage meeting earlier in the week. Please ensure that the all associated issues are moved into the appropriate milestone.
@NejcZdovc I believe we also agreed that this will get uplifted into 0.61.x during the meeting. Can you get a PR created for 0.61.x as well?
NejcZdovc
added a commit
that referenced
this pull request
Mar 7, 2019
Fixes date for recurring banner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #1789
Resolves brave/brave-browser#3481
Resolves brave/brave-browser#3494