Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong date of the first monthly tip on the monthly tip confirmation dialog #3494

Closed
btlechowski opened this issue Feb 26, 2019 · 3 comments · Fixed by brave/brave-core#1789
Closed

Comments

@btlechowski
Copy link

Follow up from #3023

Steps to Reproduce

  1. Clean profile
  2. Enable rewards
  3. Claim Grant
  4. Make a recurring tip on a site

Actual result:

Your first monthly tip will be sent on shows current date
image

Expected result:

Your first monthly tip will be sent on shows Next monthly tip date from brave://rewards/
image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.61.37 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

cc @brave/legacy_qa @NejcZdovc @ryanml

@kjozwiak
Copy link
Member

Reproduced on macOS 10.14.3 x64 using the following build:

Brave 0.61.38 Chromium: 73.0.3683.39 (Official Build) beta(64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Mac OS X

Example of the issue occurring on macOS (notice the inconsistent contribution dates):

screen shot 2019-02-26 at 4 59 55 pm

@NejcZdovc NejcZdovc self-assigned this Feb 27, 2019
@NejcZdovc NejcZdovc added this to the 0.63.x - Nightly milestone Feb 27, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Feb 28, 2019
@rebron
Copy link
Collaborator

rebron commented Mar 1, 2019

@NejcZdovc can you ask for uplift to 61.x/62.x?

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 7, 2019

Verification passed on

Brave 0.61.48 Chromium: 73.0.3683.56 (Official Build) beta (64-bit)
Revision 303af44e2f2948869279f120021c778855d76ead-refs/branch-heads/3683@{#653}
OS Windows 10 OS Build 17134.523

image
image

Verification PASSED on macOS 10.14.3 x64 using the following build:

Brave 0.61.48 Chromium: 73.0.3683.56 (Official Build) beta(64-bit)
Revision 303af44e2f2948869279f120021c778855d76ead-refs/branch-heads/3683@{#653}
OS Mac OS X

Verification passed on

Brave 0.61.49 Chromium: 73.0.3683.67 (Official Build) (64-bit)
Revision a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS Linux mint

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants