Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default behaviour for custom tabs #18620

Merged
merged 1 commit into from
May 25, 2023

Conversation

deeppandya
Copy link
Contributor

Resolves brave/brave-browser#30421

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels May 25, 2023
@deeppandya deeppandya added this to the 1.54.x - Nightly milestone May 25, 2023
@deeppandya deeppandya self-assigned this May 25, 2023
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@deeppandya deeppandya merged commit dd24dbe into master May 25, 2023
@deeppandya deeppandya deleted the update_custom_tab_behaviour branch May 25, 2023 21:20
brave-builds added a commit that referenced this pull request May 25, 2023
@hffvld
Copy link
Collaborator

hffvld commented Jun 2, 2023

Verified on Google Pixel 7 using version(s):

Device/OS: Google Pixel 7 [panther_beta-user 14 UPB2.230407.014 release-keys]
Brave build: 1.54.31
Chromium: 114.0.5735.90 (Official Build) canary (64-bit)
Revision: 386bc09e8f4f2e025eddae123f36f6263096ae49-refs/branch-heads/5735@{#1052}

STEPS:

  1. Fresh install Brave 1.54.31 > Launch the app and go through the onboarding
  2. Three-dot Menu > Settings
  3. Scroll down to see Open external links in Brave toggle switch > Verify current position
  4. Launch Gmail, for example > Open any email that contains links > Open the link > Verify, it opened in Custom Tab Mode

ACTUAL RESULTS:

  • Verified that Open external links in Brave toggle switch is set to ON by default
  • Verified that tabs are opened in Custom Tab Mode
timestamp_15-12-54_15-14-05.mp4

kjozwiak pushed a commit that referenced this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
4 participants