-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement reminder notification: If user clicks same ad 3 times #17966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emerick
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when tests are ready
tmancey
force-pushed
the
issues/29313
branch
7 times, most recently
from
April 10, 2023 11:17
7bb4fab
to
dab0df4
Compare
tmancey
force-pushed
the
issues/29313
branch
8 times, most recently
from
April 11, 2023 14:06
f533b89
to
42f4173
Compare
emerick
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kylehickinson
approved these changes
Apr 11, 2023
aseren
approved these changes
Apr 11, 2023
tmancey
force-pushed
the
issues/29313
branch
5 times, most recently
from
April 11, 2023 21:13
b751bf3
to
b91b99c
Compare
bsclifton
approved these changes
Apr 12, 2023
tmancey
force-pushed
the
issues/29313
branch
9 times, most recently
from
April 12, 2023 16:03
bba60e7
to
148e957
Compare
CI failing due to unrelated:
|
github-actions
bot
added
the
potential-layer-violation-fixes
This PR touches a BUILD.gn file with check_includes=false
label
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#29313
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Confirm a reminder push notification is shown after clicking the same ad (creative instance) every third click (configurable via griffin study
Reminder
and paramremind_user_if_clicking_the_same_ad_after
). When clicking the reminder a user should be navigated to https://support.brave.com/hc/en-us/articles/14648356808845. The reminder should showYou earn when a Brave Ads notification appears
for the title andYou don't need to click to earn, but do click if you're interested!
for the body in both system and custom push notifications.