Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reminder notification: If user clicks same ad 3 times #17966

Merged
merged 5 commits into from
Apr 13, 2023

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Apr 7, 2023

Resolves brave/brave-browser#29313

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Confirm a reminder push notification is shown after clicking the same ad (creative instance) every third click (configurable via griffin study Reminder and param remind_user_if_clicking_the_same_ad_after). When clicking the reminder a user should be navigated to https://support.brave.com/hc/en-us/articles/14648356808845. The reminder should show You earn when a Brave Ads notification appears for the title and You don't need to click to earn, but do click if you're interested! for the body in both system and custom push notifications.

@tmancey tmancey requested a review from a team as a code owner April 7, 2023 13:56
@tmancey tmancey self-assigned this Apr 7, 2023
@tmancey tmancey requested a review from emerick April 7, 2023 13:56
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when tests are ready

@tmancey tmancey force-pushed the issues/29313 branch 7 times, most recently from 7bb4fab to dab0df4 Compare April 10, 2023 11:17
@tmancey tmancey requested a review from a team as a code owner April 10, 2023 11:17
@tmancey tmancey force-pushed the issues/29313 branch 8 times, most recently from f533b89 to 42f4173 Compare April 11, 2023 14:06
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey force-pushed the issues/29313 branch 5 times, most recently from b751bf3 to b91b99c Compare April 11, 2023 21:13
@tmancey tmancey requested a review from a team as a code owner April 11, 2023 21:13
@tmancey tmancey force-pushed the issues/29313 branch 9 times, most recently from bba60e7 to 148e957 Compare April 12, 2023 16:03
@tmancey
Copy link
Collaborator Author

tmancey commented Apr 13, 2023

CI failing due to unrelated:

2023-04-12T22:15:32.349Z] 4 tests failed:

[2023-04-12T22:15:32.349Z]     All/OsIntegrationSynchronizeCommandTest.SynchronizeWorks/OSIntegrationSubManagers_Disabled (..\..\chrome\browser\web_applications\commands\os_integration_synchronize_command_unittest.cc:127)

[2023-04-12T22:15:32.349Z]     All/OsIntegrationSynchronizeCommandTest.SynchronizeWorks/OSIntegrationSubManagers_SaveStateToDB (..\..\chrome\browser\web_applications\commands\os_integration_synchronize_command_unittest.cc:127)

[2023-04-12T22:15:32.349Z]     LaunchModeRecorderTest.SlowModeChromeShortcut (..\..\chrome\browser\ui\startup\launch_mode_recorder_unittest.cc:139)

[2023-04-12T22:15:32.349Z]     LaunchModeRecorderTest.SlowModeWebAppShortcut (..\..\chrome\browser\ui\startup\launch_mode_recorder_unittest.cc:157)

@mihaiplesa mihaiplesa disabled auto-merge April 13, 2023 10:01
@mihaiplesa mihaiplesa merged commit 9e3ac4c into master Apr 13, 2023
@mihaiplesa mihaiplesa deleted the issues/29313 branch April 13, 2023 10:01
@github-actions github-actions bot added this to the 1.52.x - Nightly milestone Apr 13, 2023
@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
6 participants