Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes month and year from activity_info table #1760

Merged
merged 4 commits into from
Feb 25, 2019
Merged

Removes month and year from activity_info table #1760

merged 4 commits into from
Feb 25, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Feb 22, 2019 •
edited by jasonrsadler
Loading

Resolves brave/brave-browser#3407
Resolves brave/brave-browser#2911
Resolves brave/brave-browser#2943

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • enable rewards
  • visit site and make sure that you see site in the panel
  • make sure that it's shown in ac table

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc added this to the 0.63.x - Nightly milestone Feb 22, 2019
@NejcZdovc NejcZdovc self-assigned this Feb 22, 2019
@NejcZdovc NejcZdovc marked this pull request as ready for review February 25, 2019 08:37
jasonrsadler
jasonrsadler reviewed Feb 25, 2019
View reviewed changes
Copy link
Contributor

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. One question included.

components/brave_rewards/browser/publisher_info_database.h Outdated Show resolved Hide resolved
vendor/bat-native-ledger/src/bat_publishers.cc Outdated Show resolved Hide resolved
@jasonrsadler
Copy link
Contributor

Need test plan

@NejcZdovc
Copy link
Contributor Author

@jasonrsadler test plan added

@NejcZdovc NejcZdovc merged commit 2777859 into master Feb 25, 2019
@NejcZdovc NejcZdovc deleted the activity-refactor branch February 25, 2019 19:48
This was referenced Mar 20, 2019
Closed
Closed
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@bsclifton
Merge pull request #1760 from Liunkae/patch-1
0f59606 
Remove browser-laptop from issue template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonrsadler jasonrsadler jasonrsadler approved these changes

@ryanml ryanml Awaiting requested review from ryanml

@tmancey tmancey Awaiting requested review from tmancey

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.63.x - Release
3 participants
@NejcZdovc @jasonrsadler @tmancey