unable to exclude sites from the a-c table #2943

kjozwiak · 2019-01-14T06:07:16Z

Description

We're still getting reports from the community that even after #1693 being released in 0.58.21 which was the hotfx 3, users are still having issues excluding websites from the a-c.

Steps to Reproduce

N/A... We currently don't really have any STR. We should try working with some users that are experiencing this to see if we can either get their profiles or see if they're receiving an errors in the browser console.

Actual result:

Users can't exclude websites from the a-c table under Rewards.

Expected result:

Users should be able to exclude publishers from the a-c table under Rewards

Reproduces how often:

I'm not sure as we don't really have STR yet.

Brave version (brave://version info)

Brave	0.58.21 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision	15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}

Reproducible on current release:

Does it reproduce on brave-browser dev/beta builds?

I'm not sure as we don't really have STR yet. We'll need more information from the users that are still experiencing this issue.

Additional Information

CCing @brave/legacy_qa @NejcZdovc

The text was updated successfully, but these errors were encountered:

kjozwiak · 2019-01-14T06:10:58Z

We fixed one of the cases in #1693 but it appears that some users are still experiencing this issue.

glawrence · 2019-01-14T07:04:33Z

I have "Version 0.58.21 Chromium 71.0.3578.98 (Official Build) (64-bit)" on "mac OS Mojave 10.14.2" and still see this problem. However some sites I can exclude, others I can't, it seems that the recently added ones can be removed, not older ones. Also my "Next contribution date" is still on 18/11/2018, which suggests another problem

kjozwiak · 2019-01-14T07:29:43Z

@glawrence when you attempt to exclude websites from the auto-contribution table, do you see an errors in the browser console when clicking on the X to exclude?

GeetaSarvadnya · 2019-01-14T07:32:26Z

1+https://community.brave.com/t/auto-contribute-bat-issues/42406/2

glawrence · 2019-01-14T12:11:01Z

No, nothing

MrRobboto · 2019-01-14T17:45:03Z

@kjozwiak

To provide what I'm experiencing:

I'm noticing the same behavior people are reporting still happening in 0.58.21. After messing around with it though, I see now the behavior is latency, not complete failure.

If you just click around, it looks like nothing is happening but if you wait a few seconds you'll see it works. There's just very bad latency and no spinner to show the user something is happening in the background.

I have no console errors and consistently I can hit the "X" next to these and it works - but it takes a varying amount of time to work. Some sites it's instant, some sites it takes nearly 10 seconds to work. It's averaging around 3-4 seconds for me on ~100mbps up/down.

Hope this helps...

scmart · 2019-01-14T20:13:03Z

@kjozwiak I also see the latency issue, but that is seperate from the issue of not being able to exclude most sites, or having sites show up twice.

Also, I'm seeing no errors in console attempting to remove sites.

LaurenWags · 2019-01-14T20:15:04Z

I wonder if sites showing up twice is due to this issue #2911

MrRobboto · 2019-01-15T02:42:23Z

@scmart is there a reason you believe these are separate?

The latency I'm seeing varies depending on the site you are trying to exclude so my point was that even though people are reporting they "can't exclude some sites", that very well could be the latency issue still and they either aren't waiting long enough to see it or the latency could possibly be so bad for some sites it times out. There are several plausible ways these behaviors could be related to the same issue so with the information we have I would be hesitant to say they are separate...

MrRobboto · 2019-01-15T02:46:53Z

@LaurenWags looks plausible! In any case, the showing up twice seems unrelated to this issue. I tested the latency issue quite a bit and all the sites I tried to exclude worked perfectly fine and the UI updated perfectly as you'd expect (no double entries for me) - just really bad latency, 10+ seconds on some, not as bad on others. I could imagine it timing out on some sites causing it to fail completely for some people but I did not observe this...

scmart · 2019-01-15T04:45:19Z

@MrRobboto No, it's separate. It's not latency, it's just an inefficient sorting algorithm I assume (its all local, no network use).

MrRobboto · 2019-01-15T14:06:43Z

@scmart so your reason is because you have an assumption that there's a sorting algorithm, and it's inefficient? It's just a list sorted by percentage, updating the DOM after excluding is stupid simple. This doesn't seem to be UI or JS related, it's on the C++ side and there is async processing (background) causing latency. I'm not sure if it's local or if any network comm is required, you would need to be more familiar with the code base to know that (I'm guessing you are not).

When they fixed the bug with the JS exclude list not being initialized #1693, you can see they check it now in the new release and then it uses a message callback to invoke code on the C++ side. That then appears to be interacting with a bat ledger. I don't know if that is some local ledger or what but I don't think you would see network comm on that side in chrome dev tools, this is under-the-hood stuff - although I do not know for sure.

So I'll admit I'm speculating and not familiar with the code but I did take the time to look at it and tried to come up with a more reasonable hypothesis for why people are still reporting this. I thought the same exact thing as everyone else. I thought it just wasn't working for weeks (and it really wasn't before) but now it appears it's a delay, whether network latency, or just slow async processing (still considered latency btw).

Brave-Matt · 2019-01-16T19:53:09Z

+1 from Reddit:
https://www.reddit.com/r/brave_browser/comments/9t6m09/how_to_clear_brave_rewards_site_historylist/ee7gcvq

MrRobboto · 2019-01-17T20:49:48Z

@Brave-Matt @kjozwiak

Just an update on my observations - I was just playing around with this more and stepping through the code when I noticed there does seem to be a problem excluding sub-domains when you have already excluded the domain. This does appear to be separate from the latency issue I'm also seeing.

My guess is this is from the check on publisherKey, instead of url:

if (!state.excluded.includes(publisherKey)) {  
    chrome.send('brave_rewards.excludePublisher', [publisherKey])  
    state.excluded.push(publisherKey)  
    state = {  
        ...state,  
        excluded: state.excluded  
    }  
}

For instance - I took a look at the exclude list as it's saved to localStorage and I see it's just publisherKey, which is only the main domain. At some point I excluded google.com successfully but in my a-c list I have mail.google.com showing up as just "google.com" (twice, different bug). So that check I'm guessing fails since it only checks the publisher key which looks to be the same across subdomains...

Top of A-C list in localStorage:

Exclude list in localStorage:

Top of my A-C Table:

eljuno · 2019-02-02T04:16:56Z

+1 from Community https://community.brave.com/t/cant-remove-sites-from-contribution-list/41375?u=eljuno

scmart · 2019-02-23T02:15:41Z

This seems to be finally working correctly for me.

MJae · 2019-03-05T01:09:55Z

Still experiencing the issue. Using Version 0.60.47 Chromium: 72.0.3626.119 (Official Build) (64-bit)

LaurenWags · 2019-03-20T18:12:00Z

Verified passed with

Brave	0.63.14 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision	909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS	Mac OS X

Verified test plan from Removes month and year from activity_info table brave-core#1760
Encountered verified sites not showing correct favicon in panel - follow up to 3525 #3783 while testing
Verified able to remove sites from auto contribute table and restore them

Verification passed on

Brave	0.63.14 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision	909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS	Windows 10 OS Build 17134.523

Used test plan from brave/brave-core#1760
Also tested excluding and including of site in a-c table

Verification passed on

Brave	0.63.15 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision	909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS	Linux

Verified test plan from Removes month and year from activity_info table brave-core#1760
Encountered verified sites not showing correct favicon in panel - follow up to 3525 #3783 while testing

kjozwiak added bug needs-investigation A bug not 100% confirmed/fixed feature/rewards QA/Yes labels Jan 14, 2019

kjozwiak added this to the 1.x Backlog milestone Jan 14, 2019

kjozwiak mentioned this issue Jan 14, 2019

Rewards: unable to exclude sites from auto-contribute #1693

Closed

2 tasks

rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 18, 2019

NejcZdovc self-assigned this Jan 20, 2019

rebron removed this from the 1.x Backlog milestone Feb 7, 2019

NejcZdovc mentioned this issue Feb 22, 2019

Removes month and year from activity_info table brave/brave-core#1760

Merged

18 tasks

NejcZdovc closed this as completed in brave/brave-core#1760 Feb 25, 2019

NejcZdovc added this to the 0.63.x - Nightly milestone Feb 25, 2019

LaurenWags added the QA Pass-macOS label Mar 20, 2019

btlechowski added the QA Pass-Win64 label Mar 20, 2019

GeetaSarvadnya added the QA Pass-Linux label Mar 21, 2019

rebron added the release-notes/include label Apr 8, 2019

kjozwiak mentioned this issue Apr 24, 2019

Release notes for 0.63.x (Release Channel) #4210

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

unable to exclude sites from the a-c table #2943

unable to exclude sites from the a-c table #2943

kjozwiak commented Jan 14, 2019

kjozwiak commented Jan 14, 2019

glawrence commented Jan 14, 2019

kjozwiak commented Jan 14, 2019

GeetaSarvadnya commented Jan 14, 2019

glawrence commented Jan 14, 2019

MrRobboto commented Jan 14, 2019

scmart commented Jan 14, 2019 •

edited

Loading

LaurenWags commented Jan 14, 2019

MrRobboto commented Jan 15, 2019

MrRobboto commented Jan 15, 2019 •

edited

Loading

scmart commented Jan 15, 2019

MrRobboto commented Jan 15, 2019 •

edited

Loading

Brave-Matt commented Jan 16, 2019

MrRobboto commented Jan 17, 2019 •

edited

Loading

eljuno commented Feb 2, 2019

scmart commented Feb 23, 2019

MJae commented Mar 5, 2019

LaurenWags commented Mar 20, 2019 •

edited by GeetaSarvadnya

Loading

unable to exclude sites from the a-c table #2943

unable to exclude sites from the a-c table #2943

Comments

kjozwiak commented Jan 14, 2019

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release:

Additional Information

kjozwiak commented Jan 14, 2019

glawrence commented Jan 14, 2019

kjozwiak commented Jan 14, 2019

GeetaSarvadnya commented Jan 14, 2019

glawrence commented Jan 14, 2019

MrRobboto commented Jan 14, 2019

scmart commented Jan 14, 2019 • edited Loading

LaurenWags commented Jan 14, 2019

MrRobboto commented Jan 15, 2019

MrRobboto commented Jan 15, 2019 • edited Loading

scmart commented Jan 15, 2019

MrRobboto commented Jan 15, 2019 • edited Loading

Brave-Matt commented Jan 16, 2019

MrRobboto commented Jan 17, 2019 • edited Loading

eljuno commented Feb 2, 2019

scmart commented Feb 23, 2019

MJae commented Mar 5, 2019

LaurenWags commented Mar 20, 2019 • edited by GeetaSarvadnya Loading

scmart commented Jan 14, 2019 •

edited

Loading

MrRobboto commented Jan 15, 2019 •

edited

Loading

MrRobboto commented Jan 15, 2019 •

edited

Loading

MrRobboto commented Jan 17, 2019 •

edited

Loading

LaurenWags commented Mar 20, 2019 •

edited by GeetaSarvadnya

Loading