[Android] fix ntp background image aspect ratio

[tapanmodh]

Resolves brave/brave-browser#28450

Submitter Checklist:

• I confirm that no security/privacy review is needed, or that I have requested one
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

something that measures the "squareness" or the aspect ratio of something identifiable on one of the bg images.
Please double check private tabs are not affected

[samartnik]

lgtm

[deeppandya]

@tapanmodh what's the reasoning here to use imageview size over the screen size ? is it related to top bar and bottom bar size ?

[tapanmodh]

yes, because of use of screen size, bottom parts of ntp image was getting cut. As per design instructions, we need to display full size of image's height in the ntp.

[deeppandya]

Changes LGTM

[kjozwiak]

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.50.55 Chromium: 110.0.5481.104 (Official Build) canary (32-bit)
--- | ---
Revision | 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS | Android 13; Build/TQ1A.230205.002

Image examples from 1.50.54 Chromium: 110.0.5481.104 which is the broken build

Example	Example	Example	Example	Example

Image examples from 1.50.55 Chromium: 110.0.5481.104 which is the fixed build

Example	Example	Example	Example	Example

Example	Example	Example	Example	Example

---

@deeppandya also went through the above using his Pixel 7 Pro device and confirmed that the grid images are appearing correctly as per the following:

Example	Example	Example	Example