Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cryptocurrency widgets #16027

Merged
merged 6 commits into from
Nov 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 0 additions & 1 deletion .storybook/locale.ts
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,6 @@ let locale: Record<string, string> = {
dashboardSettingsTitle: 'Customize Dashboard',
showBackgroundImg: 'Show background image',
showBraveStats: 'Show Brave Stats',
showBinance: 'Show Binance',
braveTalkWidgetTitle: 'Brave Talk',
showClock: 'Show Clock',
showTopSites: 'Show Top Sites',
Expand Down
1 change: 0 additions & 1 deletion android/android_browser_tests.gni
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ android_test_exception_deps = [
"//brave/browser/ui/views/tabs:browser_tests",
"//brave/browser/widevine:browser_tests",
"//brave/components/brave_wallet/resources:ethereum_provider_generated_resources",
"//brave/components/crypto_dot_com/browser",
"//brave/components/de_amp/browser/test:browser_tests",
"//brave/components/sessions/browser:browser_tests",
"//brave/renderer/skus:browser_tests",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ public class BravePrivacySettings extends PrivacySettings implements ConnectionE
private static final String PREF_SHOW_AUTOCOMPLETE_IN_ADDRESS_BAR =
"show_autocomplete_in_address_bar";
private static final String PREF_AUTOCOMPLETE_TOP_SITES = "autocomplete_top_sites";
private static final String PREF_AUTOCOMPLETE_BRAVE_SUGGESTED_SITES = "autocomplete_brave_suggested_sites";
private static final String PREF_SOCIAL_BLOCKING_GOOGLE = "social_blocking_google";
private static final String PREF_SOCIAL_BLOCKING_FACEBOOK = "social_blocking_facebook";
private static final String PREF_SOCIAL_BLOCKING_TWITTER = "social_blocking_twitter";
Expand Down Expand Up @@ -114,8 +113,8 @@ public class BravePrivacySettings extends PrivacySettings implements ConnectionE
PREF_BLOCK_COOKIE_CONSENT_NOTICES, PREF_DO_NOT_TRACK, PREF_PHONE_AS_A_SECURITY_KEY,
PREF_CLOSE_TABS_ON_EXIT, PREF_SEND_P3A, PREF_SEND_CRASH_REPORTS,
PREF_BRAVE_STATS_USAGE_PING, PREF_SHOW_AUTOCOMPLETE_IN_ADDRESS_BAR,
PREF_SEARCH_SUGGESTIONS, PREF_AUTOCOMPLETE_TOP_SITES,
PREF_AUTOCOMPLETE_BRAVE_SUGGESTED_SITES, PREF_USAGE_STATS, PREF_PRIVACY_SANDBOX};
PREF_SEARCH_SUGGESTIONS, PREF_AUTOCOMPLETE_TOP_SITES, PREF_USAGE_STATS,
PREF_PRIVACY_SANDBOX};

private final int STRICT = 0;
private final int STANDARD = 1;
Expand All @@ -132,7 +131,6 @@ public class BravePrivacySettings extends PrivacySettings implements ConnectionE
private BraveDialogPreference mBlockCrosssiteCookies;
private ChromeSwitchPreference mShowAutocompleteInAddressBar;
private ChromeSwitchPreference mAutocompleteTopSites;
private ChromeSwitchPreference mAutocompleteBraveSuggestedSites;
private ChromeSwitchPreference mHttpsePref;
private ChromeSwitchPreference mDeAmpPref;
private ChromeSwitchPreference mHttpsFirstModePref;
Expand Down Expand Up @@ -256,9 +254,6 @@ public void onCreatePreferences(Bundle savedInstanceState, String rootKey) {
mAutocompleteTopSites = (ChromeSwitchPreference) findPreference(PREF_AUTOCOMPLETE_TOP_SITES);
mAutocompleteTopSites.setOnPreferenceChangeListener(this);

mAutocompleteBraveSuggestedSites = (ChromeSwitchPreference) findPreference(PREF_AUTOCOMPLETE_BRAVE_SUGGESTED_SITES);
mAutocompleteBraveSuggestedSites.setOnPreferenceChangeListener(this);

mSocialBlockingCategory =
(PreferenceCategory) findPreference(PREF_BRAVE_SOCIAL_BLOCKING_SECTION);
mSocialBlockingCategory.setOnPreferenceChangeListener(this);
Expand Down Expand Up @@ -411,16 +406,11 @@ public boolean onPreferenceChange(Preference preference, Object newValue) {
boolean autocompleteEnabled = (boolean) newValue;
mSearchSuggestions.setEnabled(autocompleteEnabled);
mAutocompleteTopSites.setEnabled(autocompleteEnabled);
mAutocompleteBraveSuggestedSites.setEnabled(autocompleteEnabled);
UserPrefs.get(Profile.getLastUsedRegularProfile())
.setBoolean(BravePref.AUTOCOMPLETE_ENABLED, autocompleteEnabled);
} else if (PREF_AUTOCOMPLETE_TOP_SITES.equals(key)) {
UserPrefs.get(Profile.getLastUsedRegularProfile())
.setBoolean(BravePref.TOP_SITE_SUGGESTIONS_ENABLED, (boolean) newValue);
} else if (PREF_AUTOCOMPLETE_BRAVE_SUGGESTED_SITES.equals(key)) {
UserPrefs.get(Profile.getLastUsedRegularProfile())
.setBoolean(
BravePref.BRAVE_SUGGESTED_SITE_SUGGESTIONS_ENABLED, (boolean) newValue);
} else if (PREF_SOCIAL_BLOCKING_GOOGLE.equals(key)) {
BravePrefServiceBridge.getInstance().setThirdPartyGoogleLoginEnabled(
(boolean) newValue);
Expand Down Expand Up @@ -558,9 +548,6 @@ private void updateBravePreferences() {
mAutocompleteTopSites.setChecked(
UserPrefs.get(Profile.getLastUsedRegularProfile())
.getBoolean(BravePref.TOP_SITE_SUGGESTIONS_ENABLED));
mAutocompleteBraveSuggestedSites.setChecked(
UserPrefs.get(Profile.getLastUsedRegularProfile())
.getBoolean(BravePref.BRAVE_SUGGESTED_SITE_SUGGESTIONS_ENABLED));

mClearBrowsingDataOnExit.setChecked(
sharedPreferences.getBoolean(PREF_CLEAR_ON_EXIT, false));
Expand All @@ -570,7 +557,6 @@ private void updateBravePreferences() {
mShowAutocompleteInAddressBar.setChecked(autocompleteEnabled);
mSearchSuggestions.setEnabled(autocompleteEnabled);
mAutocompleteTopSites.setEnabled(autocompleteEnabled);
mAutocompleteBraveSuggestedSites.setEnabled(autocompleteEnabled);
mFingerprntLanguagePref.setChecked(UserPrefs.get(Profile.getLastUsedRegularProfile())
.getBoolean(BravePref.REDUCE_LANGUAGE_ENABLED));
if (mCookieListOptInPageAndroidHandler != null) {
Expand Down
5 changes: 0 additions & 5 deletions android/java/res/xml/brave_privacy_preferences.xml
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,6 @@
android:order="25"
android:title="@string/autocomplete_top_sites_title"
android:persistent="false"/>
<org.chromium.components.browser_ui.settings.ChromeSwitchPreference
android:key="autocomplete_brave_suggested_sites"
android:title="@string/autocomplete_brave_suggested_sites_title"
android:order="25"
android:persistent="false"/>
<org.chromium.components.browser_ui.settings.ChromeSwitchPreference
android:key="send_p3a_analytics"
android:order="25"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public class BravePrivacySettingsTest {
private static final String PREF_INCOGNITO_LOCK = "incognito_lock";
private static final String PREF_PHONE_AS_A_SECURITY_KEY = "phone_as_a_security_key";

private static int BRAVE_PRIVACY_SETTINGS_NUMBER_OF_ITEMS = 23;
private static int BRAVE_PRIVACY_SETTINGS_NUMBER_OF_ITEMS = 22;

private int mItemsLeft;

Expand Down
3 changes: 0 additions & 3 deletions app/brave_settings_strings.grdp
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,6 @@
<message name="IDS_SETTINGS_APPEARANCE_SETTINGS_USE_AUTOCOMPLETE_TOP_SITES" desc="The label for settings checkbox controlling whether or not top sites show up in autocomplete">
Top sites
</message>
<message name="IDS_SETTINGS_APPEARANCE_SETTINGS_USE_AUTOCOMPLETE_BRAVE_SUGGESTED_SITES" desc="The label for settings checkbox controlling whether or not Brave suggested sites show up in autocomplete">
Suggested sites
</message>
<message name="IDS_SETTINGS_APPEARANCE_SETTINGS_USE_AUTOCOMPLETE_HISTORY" desc="The label for settings checkbox controlling whether or not browsing history shows up in autocomplete">
Browsing History
</message>
Expand Down
91 changes: 0 additions & 91 deletions browser/binance/binance_protocol_handler.cc

This file was deleted.

25 changes: 0 additions & 25 deletions browser/binance/binance_protocol_handler.h

This file was deleted.

40 changes: 0 additions & 40 deletions browser/binance/binance_service_factory.cc

This file was deleted.

36 changes: 0 additions & 36 deletions browser/binance/binance_service_factory.h

This file was deleted.

30 changes: 0 additions & 30 deletions browser/binance/sources.gni

This file was deleted.

Loading