Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cryptocurrency widgets #16027

Merged
merged 6 commits into from
Nov 25, 2022
Merged

Remove cryptocurrency widgets #16027

merged 6 commits into from
Nov 25, 2022

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Nov 18, 2022 •
edited
Loading

Resolves brave/brave-browser#26865

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Make sure that the settings are gone (in particular for use Brave suggested sites)
  • Make sure that the widgets are gone

@bbondy bbondy requested review from a team and bridiver as code owners November 18, 2022 21:38
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false labels Nov 18, 2022
@bbondy bbondy changed the title Remove widgets Remove cryptocurrency widgets Nov 18, 2022
@bbondy bbondy force-pushed the remove-widgets branch 3 times, most recently from a12f7d4 to abe8e30 Compare November 21, 2022 19:42
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

emerick
emerick approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gemini changes LGTM

@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 727de9f995aed3d766608e1a1286790f4520f163
reason: unsigned
Please follow the handbook to configure commit signing
cc: @bbondy

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@simonhong
Copy link
Member

It would be prefect if all removed prefs are also cleared.

wchen342
wchen342 approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@wchen342 wchen342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android test changes LGTM.

@bbondy bbondy requested a review from bridiver November 24, 2022 21:38
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

simonhong
simonhong approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ 👍🏼

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@bbondy bbondy merged commit 50ebdb9 into master Nov 25, 2022
@bbondy bbondy deleted the remove-widgets branch November 25, 2022 20:37
@github-actions github-actions bot added this to the 1.48.x - Nightly milestone Nov 25, 2022
@srirambv srirambv mentioned this pull request Feb 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

@wchen342 wchen342 wchen342 approved these changes

@simonhong simonhong simonhong approved these changes

@petemill petemill Awaiting requested review from petemill

@bridiver bridiver Awaiting requested review from bridiver

Assignees

@bbondy bbondy

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Milestone
1.48.x - Release
Development

Successfully merging this pull request may close these issues.

Remove widgets and supporting code
6 participants
@bbondy @brave-builds @simonhong @bridiver @emerick @wchen342