Use CDN for publisher list #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
reviewed
Feb 5, 2019
| @@ -50,9 +50,11 @@ int OnBeforeURLRequest_StaticRedirectWork( | |||
| URLPattern(URLPattern::SCHEME_HTTPS, "https://ledger.mercury.basicattentiontoken.org/*"), | |||
| URLPattern(URLPattern::SCHEME_HTTPS, "https://balance.mercury.basicattentiontoken.org/*"), | |||
| URLPattern(URLPattern::SCHEME_HTTPS, "https://publishers.basicattentiontoken.org/*"), | |||
| URLPattern(URLPattern::SCHEME_HTTPS, "https://publishers-distro.basicattentiontoken.org/*"), | |||
There was a problem hiding this comment.
can we alphabetize these?
There was a problem hiding this comment.
so you want to mix staging and prod urls?
diracdeltas
previously requested changes
Feb 5, 2019
There was a problem hiding this comment.
security review comments here: https://github.com/brave/internal/issues/504#issuecomment-460806670
16 tasks
NejcZdovc
force-pushed
the
publisher-list-cdn
branch
from
49e68f4
to
f31d5b3
Compare
NejcZdovc
force-pushed
the
publisher-list-cdn
branch
from
f31d5b3
to
ab01097
Compare
diracdeltas
reviewed
Feb 6, 2019
| { "name": "sync-staging.brave.com", "mode": "force-https", "policy": "custom", "pins": "brave"} | ||
| { "name": "sync-staging.brave.com", "policy": "custom", "mode": "force-https", "pins": "brave"}, | ||
| { "name": "publishers-distro.basicattentiontoken.org", "policy": "custom", "mode": "force-https", "pins": "brave"}, | ||
| { "name": "publishers-staging-distro.basicattentiontoken.org", "policy": "custom", "mode": "force-https", "pins": "brave"} |
|
@diracdeltas all good for this PR? |
|
@NejcZdovc yup |
|
@diracdeltas can you please approve it |
diracdeltas
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#3191
Browser PR: brave/brave-browser#3242
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: