Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to new channel file behind CDN #3191

Closed
jsecretan opened this issue Feb 1, 2019 · 2 comments · Fixed by brave/brave-core#1575
Closed

Point to new channel file behind CDN #3191

jsecretan opened this issue Feb 1, 2019 · 2 comments · Fixed by brave/brave-core#1575

Comments

@jsecretan
Copy link

jsecretan commented Feb 1, 2019

Test Plan

brave/brave-core#1575

Description

In order to make the channels file faster and more reliable for the browser to retrieve, the devops team has put it behind the CDN and defaulted the file to being gzip compressed at the edge. To ensure that both versions can run uninterrupted for existing clients, there is a new subdomain to retrieve the file. Please change the URLs to request channel files to the following:

Staging: https://publishers-staging-distro.basicattentiontoken.org/api/v1/public/channels
Production: https://publishers-distro.basicattentiontoken.org/api/v1/public/channels

Keep in mind that to take advantage of the gzipping, you need to send a ""Accept-Encoding: gzip" header and confirm that the file is uncompressed client side.

@NejcZdovc NejcZdovc modified the milestones: Dupe / Invalid / Not actionable, 1.x Backlog Feb 1, 2019
@NejcZdovc NejcZdovc self-assigned this Feb 1, 2019
@NejcZdovc NejcZdovc added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Feb 1, 2019
NejcZdovc added a commit that referenced this issue Feb 6, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Feb 6, 2019
NejcZdovc added a commit that referenced this issue Feb 7, 2019
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@NejcZdovc NejcZdovc added this to the 0.61.x - Dev milestone Feb 8, 2019
@NejcZdovc NejcZdovc modified the milestones: 0.61.x - Dev, 0.60.x - Beta Feb 11, 2019
@LaurenWags
Copy link
Member

@NejcZdovc could you clarify which flags I should be using in the terminal? I'm launching with /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --v=3 --vmodule=*rewards*=6 but maybe I'm missing a necessary flag. I'm trying to follow the test plan in brave/brave-core#1575 with

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

The only item I see about the publisher list is [55344:26115:0213/173234.735493:ERROR:rewards_service_impl.cc(165)] Failed to read file: /Users/laurenwagner/Library/Application Support/BraveSoftware/Brave-Browser-Beta/Default/publishers_list

@LaurenWags
Copy link
Member

LaurenWags commented Feb 14, 2019

Verified passed with

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X
[ REQUEST ]
> url: https://publishers-distro.basicattentiontoken.org/api/v1/public/channels
> method: GET
> content: 
> contentType: 
> headers: Accept-Encoding: gzip
[ END REQUEST ]

Verification passed on

Brave 0.60.29 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 10

Verification passed on

Brave 0.60.34 Chromium: 72.0.3626.109 (Official Build) beta(64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Linux

image

petemill pushed a commit to brave/brave-core that referenced this issue Jul 27, 2020
petemill pushed a commit to brave/brave-core that referenced this issue Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants