Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brave News] Fix bug where direct sources couldn't be unfollowed #15610

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

fallaciousreasoning
Copy link
Contributor

Resolves brave/brave-browser#26196

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Enable Brave News V2
  2. Follow a direct source (I like reactjs.org)
  3. Try and unfollow the source

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 24, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ with some nits :)

components/brave_new_tab_ui/api/brave_news/news.ts Outdated Show resolved Hide resolved
components/brave_new_tab_ui/api/brave_news/news.ts Outdated Show resolved Hide resolved
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. But as a follow-up, perhaps we should move this logic to BraveNewsController via mojom so that we're not duplicating specific details around this between Android and Desktop, etc
Follow-up issue is here brave/brave-browser#26209

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@fallaciousreasoning fallaciousreasoning changed the title Fix bug where direct sources couldn't be unfollowed [Brave News] Fix bug where direct sources couldn't be unfollowed Oct 24, 2022
@fallaciousreasoning fallaciousreasoning merged commit 60d4694 into master Oct 24, 2022
@fallaciousreasoning fallaciousreasoning deleted the bn-direct-unsub branch October 24, 2022 23:41
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the Brave News V2 UI you can't unfollow direct sources.
4 participants