Added Shields settings section

[spylogsster]

Resolves brave/brave-browser#12782

• Added Shield settings to brave://settings/content:
  • Shield status (up / down or enabled / disabled), navigates to /shields settings subpage
  • Removed Upgrade connections to HTTPS option
  • Upgrade connections to HTTPS (true / false), navigates to /shields settings subpage (removed)
• Replaced brave.https_everywhere_default by profile.default_content_setting_values.httpUpgradableResouces (removed)
• Each subpage allows to include/exclude domains same way as for other settings

shields2.mp4

Updated screenshots

Submitter Checklist:

• I confirm that no security/privacy review is needed, or that I have requested one
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

• Enable/Disable shields on different domains, make sure all domains are visible on brave://settings/content/shields
• Try to add/remove domains using Add buttons for each sections and check if shields meets this configuration

[spylogsster]

@bridiver @bsclifton I removed all HTTPSE related things due to https://github.com/brave/security/issues/1061#issuecomment-1272868332 and updated description, please take a look again, thanks

[bsclifton]

Code changes RE: the removal of httpse setting took a moment to understand, but it makes sense 😄 I build and ran this PR locally and shields up/down works great 👍

For the screen at brave://settings/content

Should the label that says Up instead say something like Sites can block trackers, ads, and fingerprinting using Shields? Maybe @rmcfadden3 can help with exact wording
cc: @rebron

[bsclifton]

Works great - just had a few items to change

The labels on brave://settings/content/braveShields should say Shields Up and Shields Down

Right now, the one which before said Up is unintentionally having the new Sites can block trackers, ads, and fingerprinting using Shields value

Once those issues are fixed, everything else looks good to me! 😄👍

[spylogsster]

Works great - just had a few items to change

The labels on brave://settings/content/braveShields should say Shields Up and Shields Down

Right now, the one which before said Up is unintentionally having the new Sites can block trackers, ads, and fingerprinting using Shields value

Once those issues are fixed, everything else looks good to me! 😄👍

done

[emerick]

I might not be understanding, but something doesn't seem quite right here to me. Where is refreshState called? I also don't see a definition for getHTTPSEverywhereEnabled.

[emerick]

If I'm right, it's most likely the root cause for these two issues:

• Strict, may break sites option is selected by default in Block fingerprinting settings dropdown in brave://settings/shields brave-browser#26068
• Block All cookies option is selected by default in Block cookies settings dropdown in brave://settings/shields brave-browser#26067