-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable reduce language feature by default #13905
Disable reduce language feature by default #13905
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls fill out the checklist. Thx!
1062c26
to
bd79697
Compare
* Disable reduce language feature by default * enable feature for browsertest
Verification PASSED on
Quick note for @brave/qa-team: We currently have the FP Language/Font feature disabled via Griffin as per brave/brave-variations#292. So with the following verification, please make sure the browser isn't restarted so it doesn't start using the various variation studies. You could also launch Brave with something similar to the following so it never contacts Griffin:
This is going to be challenging to QA but I basically just made sure the following websites are loading as expected as these were the ones reported broken by various people via brave/brave-browser#23093.
|
Broken |
Fixed |
---|---|
https://valhost.net/demo
Mentioned via brave/brave-browser#23093 (comment).
Broken |
Fixed |
---|---|
Resolves brave/brave-browser#23610
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: