Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable reduce language feature by default #13905

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Jun 22, 2022

Resolves brave/brave-browser#23610

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls fill out the checklist. Thx!

@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_disable_reduce_language_by_default branch from 1062c26 to bd79697 Compare June 22, 2022 20:41
@pilgrim-brave pilgrim-brave merged commit f27fad6 into master Jun 22, 2022
@pilgrim-brave pilgrim-brave deleted the mpilgrim_disable_reduce_language_by_default branch June 22, 2022 22:39
@pilgrim-brave pilgrim-brave restored the mpilgrim_disable_reduce_language_by_default branch June 22, 2022 22:39
brave-builds pushed a commit that referenced this pull request Jun 22, 2022
brave-builds pushed a commit that referenced this pull request Jun 22, 2022
wknapik pushed a commit that referenced this pull request Jun 23, 2022
* Disable reduce language feature by default

* enable feature for browsertest
@kjozwiak
Copy link
Member

kjozwiak commented Jun 24, 2022

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.42.22 Chromium: 103.0.5060.53 (Official Build) nightly (64-bit)
-- | --
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | Windows 11 Version 21H2 (Build 22000.739)

Quick note for @brave/qa-team: We currently have the FP Language/Font feature disabled via Griffin as per brave/brave-variations#292. So with the following verification, please make sure the browser isn't restarted so it doesn't start using the various variation studies. You could also launch Brave with something similar to the following so it never contacts Griffin:

brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/FakeSeed

This is going to be challenging to QA but I basically just made sure the following websites are loading as expected as these were the ones reported broken by various people via brave/brave-browser#23093.

https://www.ghacks.net

Mentioned via brave/brave-browser#23093 (comment).

Broken Fixed
image image

https://valhost.net/demo

Mentioned via brave/brave-browser#23093 (comment).

Broken Fixed
valBroken valFixed

@kjozwiak kjozwiak deleted the mpilgrim_disable_reduce_language_by_default branch June 24, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable "reduce language" feature by default
4 participants