Brave Ads failed confirmations should not backoff if payment tokens are not created or not ready #13824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
force-pushed
the
issues/23516
branch
2 times, most recently
from
2e80f3e to
433e35e
Compare
aseren
approved these changes
Jun 16, 2022
…re not created or not ready
|
Verification PASSED on
Viewed ads console logs: View AD1 console logs: Viewed AD2 console logs: Failed confirmation console logs: 1st AD failed confirmations logs 2nd AD faile confirmation logs:
Retry successful logs for failed confirmations:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#23516
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
GET /v2/confirmation/{confirmation_id}/paymentTokenendpoint should retry sending failed confirmations without any backoff for response status codesHTTP_NOT_FOUNDandHTTP_ACCEPTED.GET /v2/confirmation/{confirmation_id}/paymentTokenendpoint should not retry sending failed confirmations for response status codesHTTP_BAD_REQUESTandHTTP_UPGRADE_REQUIRED.GET /v2/confirmation/{confirmation_id}/paymentTokenendpoint should retry sending failed confirmations and back off exponentially for response status codes other than those above andHTTP_OKuntil the request is successful.GET /v2/confirmation/{confirmation_id}/paymentTokenendpoint should retry sending failed confirmations backing off exponentially ifGET /v1/issuers/fails to provide the user with issuers.Back off should be reset to ~15 seconds after an unblinded token is successfully redeemed.
NOTES:
Retry sending failed confirmationsin the console log for failures andSuccessfully sentfor success.