Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(22645): Toggle color fix for disable state #13493

Merged
merged 1 commit into from
May 31, 2022

Conversation

wadehrarshpreet
Copy link
Contributor

@wadehrarshpreet wadehrarshpreet commented May 26, 2022

Resolves
brave/brave-browser#22645

Screen.Recording.2022-05-26.at.11.27.33.PM.mov

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

@wadehrarshpreet
Copy link
Contributor Author

@yrliou can you review

@yrliou
Copy link
Member

yrliou commented May 27, 2022

cc @bsclifton for finding the right person in desktop UI team to review this.

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@bsclifton
Copy link
Member

Created #13510 so we can watch CI run 😄

@bsclifton
Copy link
Member

bsclifton commented May 28, 2022

@wadehrarshpreet ok we're seeing a linting error here:

/home/ubuntu/workspace/pr-brave-browser-fix-22645-linux/src/brave/components/brave_new_tab_ui/components/toggle/style.ts
error  Missing space before =>  arrow-spacing
error  Extra semicolon          @typescript-eslint/semi
error  Extra semicolon          @typescript-eslint/semi

You should be able to reproduce by running npm run tslint

@wadehrarshpreet
Copy link
Contributor Author

@bsclifton I ran the eslint --fix which fix the spacing & semicolon...but it made changes to whole file(part which I didn't touched)...so I just updated/fixed the part which I touched. Can you run the suite again.

@bsclifton
Copy link
Member

Sorry for the delay here - just pushed this latest to #13510 so we can watch over the change 😄 If things look good, I'll squash + merge

@bsclifton
Copy link
Member

OK - all CI passed in #13510; I'll get this squashed up and then we can merge 😄

@bsclifton bsclifton merged commit ba26bdc into brave:master May 31, 2022
@bsclifton bsclifton added this to the 1.41.x - Nightly milestone May 31, 2022
@bsclifton
Copy link
Member

Huge thanks @wadehrarshpreet for the PR 😄

@wadehrarshpreet wadehrarshpreet deleted the fix/22645 branch May 31, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants