-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(22645): Toggle color fix for disable state #13493
Conversation
@yrliou can you review |
cc @bsclifton for finding the right person in desktop UI team to review this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Created #13510 so we can watch CI run 😄 |
@wadehrarshpreet ok we're seeing a linting error here:
You should be able to reproduce by running |
@bsclifton I ran the |
Sorry for the delay here - just pushed this latest to #13510 so we can watch over the change 😄 If things look good, I'll squash + merge |
OK - all CI passed in #13510; I'll get this squashed up and then we can merge 😄 |
Huge thanks @wadehrarshpreet for the PR 😄 |
Resolves
brave/brave-browser#22645
Screen.Recording.2022-05-26.at.11.27.33.PM.mov
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on