Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Shields: enable v2 UI refresh by default and introduce flag for legacy v1 #12586

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

petemill
Copy link
Member

@petemill petemill commented Mar 12, 2022

Resolves brave/brave-browser#18630

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • There is only 1 shields button and it is v2 UI refresh button.
  • Enabling the flag for shields-v1 additionally adds the old shields button

@petemill petemill requested review from bsclifton and nullhook March 12, 2022 04:45
@petemill petemill self-assigned this Mar 12, 2022
@nullhook
Copy link
Contributor

Should we really merge this before? #12523

Copy link
Contributor

@nullhook nullhook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petemill petemill added this to the 1.38.x - Nightly milestone Mar 14, 2022
@petemill petemill merged commit e4ae8a4 into master Mar 17, 2022
@petemill petemill deleted the shields-v1-flag branch March 17, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shields v2 UI Refresh
2 participants