Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes image for unverified from tip table #1186

Merged
merged 1 commit into from
Dec 23, 2018
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Dec 23, 2018

Resolves brave/brave-browser#2715

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • enable rewards
  • claim grant
  • go to youtube channel that is not verified
  • tip this channel
  • go to settings and make sure that tip table don't show the image

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc merged commit 929bdb9 into master Dec 23, 2018
@NejcZdovc NejcZdovc deleted the tip-unverified branch December 23, 2018 18:39
NejcZdovc added a commit that referenced this pull request Dec 23, 2018
Removes image for unverified from tip table
NejcZdovc added a commit that referenced this pull request Dec 23, 2018
Removes image for unverified from tip table
NejcZdovc added a commit that referenced this pull request Dec 23, 2018
Removes image for unverified from tip table
@NejcZdovc
Copy link
Contributor Author

master (0.61) 929bdb9
0.60 865ee71
0.59 64b9f8e
0.58 e181e50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove YT images for unverified publishers in Tip table on Brave Rewards
3 participants