Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove YT images for unverified publishers in Tip table on Brave Rewards #2715

Closed
mandar-brave opened this issue Dec 23, 2018 · 3 comments · Fixed by brave/brave-core#1186
Closed
Assignees
Labels
feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes

Comments

@mandar-brave
Copy link

mandar-brave commented Dec 23, 2018

YT icons for unverified publishers are showing up in tip table.

cc @diracdeltas @NejcZdovc @rebron

@diracdeltas
Copy link
Member

diracdeltas commented Dec 23, 2018 via email

@NejcZdovc
Copy link
Contributor

@diracdeltas we don't have twitch support yet

@kjozwiak
Copy link
Member

kjozwiak commented Dec 23, 2018

Verified using the following platforms:

Builds being used:

Brave 0.58.18 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}

Example of verified vs unverified using Ubuntu 18.04 x64:

screen shot 2018-12-23 at 5 26 42 pm

Example of verified vs unverified using macOS 10.14.2 x64:

screen shot 2018-12-23 at 4 45 09 pm

Example of verified vs unverified using Windows 10 x64:

screen shot 2018-12-23 at 6 35 07 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants