Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(uplift 1.33.x) 10973 and 11234 #11269

Merged
merged 2 commits into from
Nov 27, 2021
Merged

(uplift 1.33.x) 10973 and 11234 #11269

merged 2 commits into from
Nov 27, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Nov 24, 2021 •
edited by kjozwiak
Loading

Uplift of #10973 #11234
Resolves brave/brave-browser#19678
Resolves brave/brave-browser#19004

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@spylogsster spylogsster requested a review from a team November 24, 2021 08:36
@spylogsster spylogsster requested a review from a team as a code owner November 24, 2021 08:36
@spylogsster spylogsster changed the title 10973 and 11234 uplift (uplift 1.33.x) 10973 and 11234 Nov 25, 2021
@kjozwiak kjozwiak added this to the 1.33.x - Beta milestone Nov 27, 2021
kjozwiak
kjozwiak approved these changes Nov 27, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.33.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #10973 (comment) & #11234 (comment).

@kjozwiak kjozwiak merged commit 32095be into 1.33.x Nov 27, 2021
@kjozwiak kjozwiak deleted the pr11234_uplift branch November 27, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@spylogsster spylogsster

Labels
None yet
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@spylogsster @kjozwiak