Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add menu to allow to edit/remove networks on wallet page #19004

Closed
spylogsster opened this issue Oct 26, 2021 · 1 comment · Fixed by brave/brave-core#10973
Closed

Add menu to allow to edit/remove networks on wallet page #19004

spylogsster opened this issue Oct 26, 2021 · 1 comment · Fixed by brave/brave-core#10973
Assignees
@spylogsster
Labels
feature/web3/wallet Integrating Ethereum+ wallet support native-change This change is on the Chromium side, usually in C++ not-mvp OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.33.x - Release

Comments

@spylogsster
Copy link

  • Add menu like in ipfs keys to Edit/Remove networks
  • Add hand cursor for double click indication

image
@spylogsster spylogsster changed the title Add menu to allow edit/remove networks on wallet page Add menu to allow to edit/remove networks on wallet page Oct 26, 2021
@bbondy bbondy added native-change This change is on the Chromium side, usually in C++ priority/P2 A bad problem. We might uplift this to the next planned release. labels Oct 27, 2021
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Nov 3, 2021
@spylogsster spylogsster self-assigned this Nov 8, 2021
@bbondy bbondy added the not-mvp label Nov 9, 2021
@spylogsster spylogsster mentioned this issue Nov 10, 2021
Merged
24 tasks
@spylogsster spylogsster added this to the 1.34.x - Nightly milestone Nov 10, 2021
@spylogsster spylogsster mentioned this issue Nov 24, 2021
Merged
7 tasks
@srirambv
Copy link
Contributor

srirambv commented Nov 29, 2021 •
edited
Loading

Verification passed on

Brave 1.33.93 Chromium: 96.0.4664.45 (Official Build) beta (arm64)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS macOS Version 12.0.1 (Build 21A559)
  • Verified menu has two entries for Edit and Remove
  • Verified clicking on Remove shows confirmation before removing it
  • Verified clicking on edit brings up the edit modal
  • Verified able to successfully remove the network from list after clicking ok on the confirmation popup
image image

Verification passed on

Brave 1.33.93 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Windows 11 Version Dev (Build 22504.1010)
  • Verified menu has two entries for Edit and Remove
  • Verified clicking on Remove shows confirmation before removing it
  • Verified clicking on edit brings up the edit modal
  • Verified able to successfully remove the network from list after clicking ok on the confirmation popup
image image

Verification passed on

Brave 1.33.93 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Linux
  • Verified menu has two entries for Edit and Remove
  • Verified clicking on Remove shows confirmation before removing it
  • Verified clicking on edit brings up the edit modal
  • Verified able to successfully remove the network from list after clicking ok on the confirmation popup
image image

@LaurenWags LaurenWags mentioned this issue Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
feature/web3/wallet Integrating Ethereum+ wallet support native-change This change is on the Chromium side, usually in C++ not-mvp OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging a pull request may close this issue.

Add menu to edit wallet networks brave/brave-core
4 participants
@bbondy @kjozwiak @spylogsster @srirambv