Changes to sync QR code for Desktop and Android #11199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
potential-layer-violation-fixes
AlexeyBarabash
force-pushed
the
sync_qr_v2
branch
3 times, most recently
from
f0430e8 to
f94024e
Compare
AlexeyBarabash
changed the title
AlexeyBarabash
force-pushed
the
sync_qr_v2
branch
2 times, most recently
from
e6e11d1 to
8270434
Compare
AlexeyBarabash
added
feature/sync
and removed
CI/skip
AlexeyBarabash
force-pushed
the
sync_qr_v2
branch
2 times, most recently
from
984af09 to
75d0ac6
Compare
AlexeyBarabash
force-pushed
the
sync_qr_v2
branch
from
75d0ac6 to
783eec0
Compare
fmarier
approved these changes
Nov 26, 2021
bsclifton
approved these changes
Nov 29, 2021
darkdh
reviewed
Nov 30, 2021
Comment on lines
106
to
107
| } else if (version_value->is_int()) { | ||
| qr_data->version = version_value->GetInt(); |
There was a problem hiding this comment.
We should only accept string version as spec specified.
There was a problem hiding this comment.
I had doubts here. Version by meaning is integer and it is for sure less than 32 bits. That is why I made it to be both string or integers.
But your comment clears the things out. I will follow the spec with only integer for version.
There was a problem hiding this comment.
fixed here:
fa9cdb4
- version field of QR data is strictly string; - added validation for seed hex by checking the passphrase words number.
AlexeyBarabash
added a commit
that referenced
this pull request
Dec 1, 2021
Sync QR code v2 for Desktop and Android
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#19550
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
See https://docs.google.com/document/d/1w7tEPNj4GaTCEekmj4Ala0BiDSFQxSAA1V7_uOQ4ZTo/edit#heading=h.6fxbe025utui
Own tests succeeded except the lines with iOS involved