Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out iOS tracking parameters #10815

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Filter out iOS tracking parameters #10815

merged 1 commit into from
Nov 2, 2021

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Nov 2, 2021

Resolves brave/brave-browser#18758

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open https://brave.com/?untouched=yes and check that the untouched parameter is present in the URL.
  2. Open https://brave.com/?wbraid=foo and check that the wbraid parameter is removed from the URL.
  3. Open https://brave.com/?gbraid=bar and check that the gbraid parameter is removed from the URL.

@fmarier fmarier requested a review from iefremov as a code owner November 2, 2021 00:20
@fmarier fmarier self-assigned this Nov 2, 2021
@fmarier fmarier force-pushed the wbraid-gbraid-18758 branch from a395c80 to 6467824 Compare November 2, 2021 04:14
@fmarier fmarier merged commit 4c13a35 into master Nov 2, 2021
@fmarier fmarier deleted the wbraid-gbraid-18758 branch November 2, 2021 16:35
@fmarier fmarier added this to the 1.33.x - Nightly milestone Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Google's new iOS URL parameters to the query string filter
2 participants