Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 94.0.4606.61 to Chromium 94.0.4606.71 (1.30.x). #18490

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

mkarolin
Copy link
Contributor

@mkarolin mkarolin commented Oct 1, 2021

Fixes #18477
Related PR: brave/brave-core#10335

Uplift from #18478

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Upgrade from Chromium 94.0.4606.61 to Chromium 94.0.4606.71
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.31.x is approved after consulting with @brave/uplift-approvers

macOS failed due to RewardsContributionBrowserTest.SplitProcessOneTimeTip & RewardsContributionBrowserTest.SplitProcessorAutoContribution which are known intermittent failures as per #13883 & #13884 and do not block uplift.

@LaurenWags LaurenWags merged commit e18d446 into 1.30.x Oct 1, 2021
@LaurenWags LaurenWags deleted the 94.0.4606.71_master_122-1.30.x branch October 1, 2021 13:45
@LaurenWags LaurenWags added this to the 1.30.x - Release #2 milestone Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants