Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tab Page Grid alignment should be more dynamic #7884

Closed
petemill opened this issue Jan 23, 2020 · 1 comment · Fixed by brave/brave-core#4075
Closed

New Tab Page Grid alignment should be more dynamic #7884

petemill opened this issue Jan 23, 2020 · 1 comment · Fixed by brave/brave-core#4075

Comments

@petemill
Copy link
Member

  • Allow items to fill in gaps left by other items which are turned off
  • Allow any item to fit next to any item, even if it occupies 2 rows (e.g. Branded Wallpaper Logo item, or Rewards item)

Test plan on brave/brave-core#4075 (Items 9 and 10)

@kjozwiak
Copy link
Member

kjozwiak commented Feb 4, 2020

Verification PASSED on macOS 10.15.3 x64 using the following build:

Brave 1.3.108 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS macOS Version 10.15.3 (Build 19D76)

Different window sizes

Screen Shot 2020-02-04 at 4 45 50 PM

Screen Shot 2020-02-04 at 4 46 03 PM

Screen Shot 2020-02-04 at 4 46 15 PM

Stats widget disabled

Screen Shot 2020-02-04 at 4 47 06 PM

Screen Shot 2020-02-04 at 4 50 23 PM

Screen Shot 2020-02-04 at 4 50 07 PM

Clock widget disabled

Screen Shot 2020-02-04 at 4 50 59 PM

Screen Shot 2020-02-04 at 4 51 08 PM

Screen Shot 2020-02-04 at 4 51 19 PM

Top Sites widget disabled

Screen Shot 2020-02-04 at 4 53 25 PM

Screen Shot 2020-02-04 at 4 55 00 PM

Screen Shot 2020-02-04 at 4 55 08 PM

Other variations

Screen Shot 2020-02-04 at 4 56 10 PM

Screen Shot 2020-02-04 at 4 59 40 PM

Verification passed on

Brave 1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Different window sizes

image

image

image

Stats widget disabled

image

image

image

Clock widget disabled

image

image

image

Top Sites widget disabled

image

image

image

Verification passed on

Brave 1.3.111 Chromium: 80.0.3987.85 (Official Build) (64-bit)
Revision 583b05dfa4ffc657f0f7c5cc13f53aa17c9a5bcf-refs/branch-heads/3987@{#791}
OS Ubuntu 18.04 LTS

Different window sizes

image
image
image

Stats widget disabled

image
image

Clock widget disabled

image
image

Top Sites widget disabled

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment