-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand contributon_info table #6942
Labels
feature/rewards
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/exclude
Milestone
Comments
NejcZdovc
added
feature/rewards
priority/P2
A bad problem. We might uplift this to the next planned release.
labels
Nov 15, 2019
This was referenced Nov 15, 2019
blocked on #6544 |
@NejcZdovc what should be manually QA'd with this issue? |
@LaurenWags test plan could be that you do couple of contributions and make sure that this two tables are populated correctly |
mix of AC, one time tips and recurring tips? |
yup |
Verified passed with
Verification passed on
Verification passed on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/rewards
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/exclude
Test Plan
Perform several auto contributes, one time tips, and recurring tips and confirm the
contribution_info
andcontribution_info_publishers
tables are populated as expected per #6942 (comment)Check AC, one time tips, and recurring tips using:
Right now this is how table looks like:
We will need to expand it so that we can handle retry logic and logging an actual contribution data, so that we don't need ledger_state logging anymore. Because VG simplified things a lot, tables should be quite clean. For now VG don't need any special data that needs to be stored so we don't need dumping table for it.
This is a current proposal:
The text was updated successfully, but these errors were encountered: