Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry logic for unblided tokens contribution #6940

Closed
NejcZdovc opened this issue Nov 15, 2019 · 1 comment · Fixed by brave/brave-core#4372
Closed

Retry logic for unblided tokens contribution #6940

NejcZdovc opened this issue Nov 15, 2019 · 1 comment · Fixed by brave/brave-core#4372
Assignees
@NejcZdovc
Labels
feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Milestone
1.3.x - Release

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Nov 15, 2019 •
edited
Loading

When we start contribution process we need to log all contribution data in the db. This should also include step and retry number. When we are going through publishers we need to log progress per publisher as well. If publisher submit fails we need to retry it.
@NejcZdovc NejcZdovc added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. labels Nov 15, 2019
@NejcZdovc NejcZdovc self-assigned this Nov 15, 2019
@NejcZdovc NejcZdovc mentioned this issue Nov 15, 2019
Closed
13 tasks
@NejcZdovc
Copy link
Contributor Author

blocked on #6942

@NejcZdovc NejcZdovc removed the blocked label Nov 19, 2019
@NejcZdovc NejcZdovc removed their assignment Jan 8, 2020
@NejcZdovc NejcZdovc added this to the 1.3.x - Beta milestone Jan 14, 2020
@NejcZdovc NejcZdovc removed the blocked label Jan 14, 2020
@NejcZdovc NejcZdovc self-assigned this Jan 14, 2020
@NejcZdovc NejcZdovc mentioned this issue Jan 14, 2020
Merged
32 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 16, 2020
@NejcZdovc
Adds delays for suggestion api
0156052 
Resolves brave/brave-browser#7709
Resolves brave/brave-browser#6940
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 20, 2020
@NejcZdovc
Adds delays for suggestion api
111c264 
Resolves brave/brave-browser#7709
Resolves brave/brave-browser#6940
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 22, 2020
@NejcZdovc
Adds delays for suggestion api
2ee5944 
Resolves brave/brave-browser#7709
Resolves brave/brave-browser#6940
This was referenced Jan 27, 2020
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
None yet
Milestone
1.3.x - Release
Development

Successfully merging a pull request may close this issue.

Adds delays for suggestion api brave/brave-core
2 participants
@NejcZdovc @LaurenWags