-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ads Settings should display BAT with 1 decimal place #6774
Comments
@ryanml @NejcZdovc I'm not finding this in 1.2.x but it is merged into master (1.3.x) per https://github.com/brave/brave-core/commits/master?after=0342c2949a9ea06ff3ea146ba0c51665549c91e1+279. Can the milestone on this issue and the PR be adjusted to reflect 1.3.x or are you going to be requesting uplift to 1.2.x? Marking as |
Any updates on the concerns raised by @LaurenWags ? |
@LaurenWags yup this was marked wrongly, changed to 1.3 |
Verification passed on
Verified test plan from the description. Also verified other instances of BAT values and made sure they all have 1 decimal place Verified passed with
Verification passed on
|
Test plan:
Expected:
Estimated pending rewards displays as
0.0 BAT
Actual:
The text was updated successfully, but these errors were encountered: