Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get geolocations to work with our endpoint #48

Closed
bbondy opened this issue Jan 3, 2018 · 2 comments
Closed

Get geolocations to work with our endpoint #48

bbondy opened this issue Jan 3, 2018 · 2 comments
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@bbondy
Copy link
Member

bbondy commented Jan 3, 2018

See in muon:
git grep google_api_endpoint
git grep google_api_key

See brave/brave:
git grep antimuon_google_api_endpoint
git grep antimuon_google_api_key
@bbondy bbondy added this to the Milestone 2: To offer Installable and updatable builds milestone Jan 3, 2018
@bbondy bbondy mentioned this issue Jan 12, 2018
Merged
@bbondy bbondy modified the milestones: Milestone 2: To offer Installable and updatable builds, Milestone 1: To be able to open source the repo Jan 12, 2018
@bbondy bbondy closed this as completed Jan 23, 2018
cezaraugusto pushed a commit that referenced this issue May 15, 2018
@bbondy
Merge pull request #48 from brave/issue-81
1b5b3d2 
Ensure ContentSettingsStore::RegisterExtension is called for components
@bbondy bbondy modified the milestones: Milestone 1: To be able to open source the repo, Releasable builds Jun 13, 2018
@bbondy
Copy link
Member Author

bbondy commented Aug 18, 2018

QA notes: just make sure geolocations works.

@srirambv srirambv removed the QA/No label Aug 20, 2018
@srirambv srirambv mentioned this issue Aug 20, 2018
Closed
@srirambv
Copy link
Contributor

srirambv commented Sep 21, 2018 •
edited by kjozwiak
Loading

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Verification PASSED on:

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

@bbondy bbondy added the QA/Yes label Sep 27, 2018
@iefremov iefremov mentioned this issue Nov 27, 2020
Closed
@bridiver bridiver mentioned this issue Mar 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

No branches or pull requests
4 participants
@bbondy @kjozwiak @srirambv @GeetaSarvadnya