Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build a replacement for GCM/FCM (used for Desktop notifications) #4431

Closed
bsclifton opened this issue May 14, 2019 · 19 comments
Closed

Build a replacement for GCM/FCM (used for Desktop notifications) #4431

bsclifton opened this issue May 14, 2019 · 19 comments
Labels
closed/wontfix feature/notifications infrastructure needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution.

Comments

@bsclifton
Copy link
Member

bsclifton commented May 14, 2019 •
edited
Loading

Task

Chromium/Chrome have GCM (Google Cloud Messaging - deprecated April 2018) and FCM (Firebase Cloud Messaging) enabled. These protocols are used in delivering notifications on the Desktop product (at least, on Chromium/Chrome). Because these reach out to Google, we have disabled them:

Implementing this task would mean standing up a service (are there any off-the-shelf solutions?) that can handle routing these notifications in a private and secure way

Implementation of this task would unblock #2362

Associated Project

#2362

Also see Slack conversation at https://bravesoftware.slack.com/archives/C7VLGSR55/p1557485850144300
@bsclifton
Copy link
Member Author

cc: @diracdeltas @bbondy @bridiver from the discussion linked to above
cc: @w0ts0n @hspencer77 @bkero on the devops/infrastructure side of house

@bsclifton
Copy link
Member Author

Additional comment, per @iefremov:

Just a small note that potentially we are not bound to GCM/FCM. Push machinery is well abstracted inside Chromium (see PushMessagingService), so if we have problems with deploying something FCM-compatible on the server side, we can pick another solution and (relatively) straightforwardly support it in the browser.

@bsclifton bsclifton transferred this issue from another repository May 14, 2019
@bsclifton bsclifton added infrastructure needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. feature/notifications labels May 14, 2019
@bsclifton
Copy link
Member Author

cc: @rebron for prioritization

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 24, 2019
@simonhong simonhong mentioned this issue Jun 26, 2019
Open
@rebron rebron mentioned this issue Jul 31, 2019
Closed
@WorldLanguages
Copy link

I honestly don't care if these services reach Google. Could there be some way push notifications can be enabled in Brave? A flag, something? Give users a chance to choose what to do until you implement an alternative to GCM/FCM, please.

@szaimen
Copy link

szaimen commented Sep 3, 2019

Any update on this?

@bsclifton
Copy link
Member Author

Latest update:

  • We should be able to get desktop notifications implemented without resolving this issue
  • When resolving this issue, we might try to leverage the work Mozilla has done (including standing up our own server)

Will give an update in the other issue about where we're at 😄

@mlncstr
Copy link

mlncstr commented Sep 6, 2019

And here's how our entire development team now transitions off of Brave...

@szaimen
Copy link

szaimen commented Sep 6, 2019

@MarkMakes What?

@uxdxdev
Copy link

uxdxdev commented Oct 19, 2019

Also hitting this issue on Brave working with Googles cloud messaging. Any updates?

@LesterCovax
Copy link

Working for me now, at least with JoinApp (which was broken for a long time due to this). More info here: #2408 (comment)

@aboydpoi
Copy link

Any update on this? @LesterCovax @bsclifton

@LesterCovax
Copy link

@aboydpoi What do you mean? I said it was working for me. 😕

@bsclifton
Copy link
Member Author

bsclifton commented Dec 30, 2019 •
edited
Loading

With the new setting, the feature itself should work great
Screen Shot 2019-12-30 at 10 03 22 AM

No progress or updates on a complete replacement for GCM/FCM. As shared above, Mozilla does have an implementation that we could explore, but we haven't prioritized this work (yet)

@totomaze
Copy link

totomaze commented Jan 2, 2020

With the new setting, the feature itself should work great
Screen Shot 2019-12-30 at 10 03 22 AM

No progress or updates on a complete replacement for GCM/FCM. As shared above, Mozilla does have an implementation that we could explore, but we haven't prioritized this work (yet)

Where is this option in Version 0.70.123 Chromium: 78.0.3904.97 (Official Build) (64-bit) ?

@bsclifton
Copy link
Member Author

@totomaze it's not there, as that is a fairly old build. Can you please update to a newer build? Current release channel is 1.1.23

@Fluf22
Copy link

Fluf22 commented Jun 16, 2020

Hey!
Any news on the prioritization of this issue?
Thanks 😁

@LesterCovax
Copy link

LesterCovax commented Jul 15, 2020 via email

@shadow1349
Copy link

shadow1349 commented Nov 25, 2020 •
edited
Loading

I'm not sure why, but blocking FCM has also broken Firebase Callable Functions in Angular. Here's a comment I made for it:

angular/angularfire#2475 (comment)

I don't think there is much the Angular team can do to fix it since it seems the issue is on Brave itself. Now my whole app is broken in Brave since I rely on callable functions.

@bsclifton bsclifton removed the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 28, 2024
@bsclifton
Copy link
Member Author

Closing as unplanned. We can re-open or create a new issue if we want to consider this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/wontfix feature/notifications infrastructure needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests