Desktop push notifications do not always function (twitter, reddit, etc) #2362

Brave-Matt · 2018-12-05T03:01:56Z

Description

I've seen DT notifications for various sites (gmail, community, twitter, reddit, etc) work without any issues or conflicts with settings. DT notifications for Youtube however do not work. Alert never actually get displayed in b-c (nor does it play the sound).

This was tested using Dev, Beta and Release builds. Windows 7/Windows 10.
Shields up/down and changing global shields have no effect.

Steps to Reproduce

Visit YouTube, sign into YT account
Verify that:

Notifications from YT are set to "Allowed", either by prompt on visit or manual entry (see Match content setting rules to allow subdomain and port specifications #1775 ) in browser
Desktop notifications set to "on" in YT (Click the notification icon (bell) --> Gear icon --> Notification Settings --> Desktop Notifications). Note that it will display the Chrome icon instead of the Brave icon.
Notifications are enabled in Windows system settings

Try and provoke a notification from you YT account. I tested this by sending both messages, and commenting on a video I put on my channel from a separate account.
Adjust Shields settings (global and/or panel), and repeat

Actual result:

No notification is displayed on desktop. Notifications do appear on YT.

Expected result:

Desktop notification appears as intended, notifications appear on YT as well.

Reproduces how often:

Easily/always

Brave version (brave://version info)

Release: 0.56.15
Beta: 0.57.8
Dev: 0.58.10

Reproducible on current release:

Yes

Does it reproduce on brave-browser dev/beta builds?
Yes

Website problems only:

Does the issue resolve itself when disabling Brave Shields?
No
Is the issue reproducible on the latest version of Chrome?
No - notifications are displayed as intended. I was tricked by this more than once.

Additional Information

User(s) also reporting this on Community:
https://community.brave.com/t/version-0-56-7-chromium-70-0-3538-77-official-build-beta-64-bit-youtube-notifications-or-lack-of/36771/26

Brave-Matt · 2018-12-13T23:45:13Z

May be related to this:
https://www.reddit.com/r/brave_browser/comments/a5xy25/cant_enable_facebook_notifications_in_brave/

Brave-Matt · 2019-03-29T17:17:45Z

This seems to be true for Twitter as well -- Navigating to "Web notifiactions" in Twitter's settings displays the following message:

Note that I have seen the offer to enable web notifications on Twitter in previous releases.

Brave-Matt · 2019-04-02T22:03:07Z

Several +1's from Community:
https://community.brave.com/t/notification-enabled-but-not-working/49594/8

Brave-Matt · 2019-04-04T17:53:48Z

+1 from reddit: https://www.reddit.com/r/brave_browser/comments/b90b4o/release_channel_version_06250_is_live/ek30sbv?utm_source=share&utm_medium=web2x

Brave-Matt · 2019-04-09T07:09:53Z

+1 Community:
https://community.brave.com/t/google-drive-desktop-notifications-are-broken-in-brave-for-windows/52498/7

felschr · 2019-04-09T14:16:39Z

I'm pretty sure the reason why it's not working is #2143
On Android it's still working atm because FCM wasn't disabled there.

I'm not entirely familiar with Chrome's history with FCM but I think they initially offered a custom FCM/GCM API (https://developers.chrome.com/extensions/gcm) and later added support for the Push API once it was standardised.
Maybe they've reused parts of the FCM implementation for the Push API. So #2143 probably removed too much.
I'm not even sure if there is still such a thing as an FCM API in Chrome or if they maybe just used that as an internal name for their Push API implementation. At least chrome.gcm is not available anymore.

Hopefully this contains some new insight.

mrdavey · 2019-05-01T18:19:37Z

I'm having the same issue and suspect that @felschr is correct that it is FCM related.
I'm testing web push notifications using Firebase FCM and it works perfectly on Chrome, Opera, and Firefox, but not Brave. (No Safari as it doesn't support Push API)

According to FCM documentation:

The FCM JavaScript API lets you receive notification messages in web apps running in browsers that support the Push API. This includes the browser versions listed in this support matrix.

It seems Brave's Push API is broken.

Brave-Matt · 2019-05-06T16:52:39Z

More +1s:
https://community.brave.com/t/notification-enabled-but-not-working/49594/41

bbondy · 2019-05-06T17:56:04Z

@simonhong could you take a look?

simonhong · 2019-05-10T04:32:08Z

On my local, I debugged with gmail and youtube service on MacOS.
With youtube, renderer process requests notification displaying via NotificationManager::DisplayPersistentNotification().
With gmail, NotificationManager::DisplayNonPersistentNotification() was used.
On Brave, I only can get gmail notification.
On Chromium, both notifications are displayed.
And according to notification spec and comments, persistent notification is a notification with an associated service worker registration.

I think persistent notification seem not working properly on Brave.
But not sure it is youtube specific problem or not. Needs more debugging.

Push notification doesn't work with Brave. - https://serviceworke.rs/push-simple_demo.html

simonhong · 2019-05-13T04:20:18Z

After re-enabling GCM client (we disabled by #1716), I got notification from youtube and demo of https://serviceworke.rs/push-simple_demo.html works well.

However, still web notification of twitter can't be enabled. (~~Same as chromium~~)

Brave-Matt · 2019-05-14T18:15:57Z

+1 https://community.brave.com/t/notification-enabled-but-not-working/49594/53?u=mattches

Note that 9 new users have joined the above thread confirming that they're unable to receive notifications.

WorldLanguages · 2019-06-24T20:23:57Z

After re-enabling GCM client (we disabled by #1716), I got notification from youtube and demo of https://serviceworke.rs/push-simple_demo.html works well.

However, still web notification of twitter can't be enabled. (~~Same as chromium~~)

@simonhong This isn't working in latest Brave Stable, even with shields off: https://serviceworke.rs/push-simple_demo.html

snowbound · 2019-06-24T21:41:54Z

I went back to using Firefox rather than continue to use Chrome and put up with Google antics. On the Chromium side both Brave and MS Edge Chromium beta and dev have the notification issues

simonhong · 2019-06-26T00:57:55Z

@WorldLanguages This issue is blocked by #4431

RealAlphabet · 2024-07-17T14:46:46Z

Any news on this problem? Is the chrome.gcm API still disabled? Is Web Push working?

A known issue in Brave (brave/brave-browser#2362 (comment)) prevents push notifications unless "Use Google Services for Push Messaging" is enabled in settings. Before this commit, attempting to enable desktop notifications in Brave resulted in a traceback. This commit handles the failure by displaying an error message and suggesting enabling Google Services when using Brave. task-4191214

A known issue in Brave (brave/brave-browser#2362 (comment)) prevents push notifications unless "Use Google Services for Push Messaging" is enabled in settings. Before this commit, attempting to enable desktop notifications in Brave resulted in a traceback. This commit handles the failure by displaying an error message and suggesting enabling Google Services when using Brave. task-4191214 closes #183968 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

A known issue in Brave (brave/brave-browser#2362 (comment)) prevents push notifications unless "Use Google Services for Push Messaging" is enabled in settings. Before this commit, attempting to enable desktop notifications in Brave resulted in a traceback. This commit handles the failure by displaying an error message and suggesting enabling Google Services when using Brave. task-4191214 X-original-commit: 491889c

A known issue in Brave (brave/brave-browser#2362 (comment)) prevents push notifications unless "Use Google Services for Push Messaging" is enabled in settings. Before this commit, attempting to enable desktop notifications in Brave resulted in a traceback. This commit handles the failure by displaying an error message and suggesting enabling Google Services when using Brave. task-4191214 closes #184394 X-original-commit: 491889c Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

A known issue in Brave (brave/brave-browser#2362 (comment)) prevents push notifications unless "Use Google Services for Push Messaging" is enabled in settings. Before this commit, attempting to enable desktop notifications in Brave resulted in a traceback. This commit handles the failure by displaying an error message and suggesting enabling Google Services when using Brave. task-4191214 X-original-commit: 1f81afa

A known issue in Brave (brave/brave-browser#2362 (comment)) prevents push notifications unless "Use Google Services for Push Messaging" is enabled in settings. Before this commit, attempting to enable desktop notifications in Brave resulted in a traceback. This commit handles the failure by displaying an error message and suggesting enabling Google Services when using Brave. task-4191214 closes #184935 X-original-commit: 1f81afa Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

A known issue in Brave (brave/brave-browser#2362 (comment)) prevents push notifications unless "Use Google Services for Push Messaging" is enabled in settings. Before this commit, attempting to enable desktop notifications in Brave resulted in a traceback. This commit handles the failure by displaying an error message and suggesting enabling Google Services when using Brave. task-4191214 closes #184895 X-original-commit: 1f81afa Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

A known issue in Brave (brave/brave-browser#2362 (comment)) prevents push notifications unless "Use Google Services for Push Messaging" is enabled in settings. Before this commit, attempting to enable desktop notifications in Brave resulted in a traceback. This commit handles the failure by displaying an error message and suggesting enabling Google Services when using Brave. task-4191214 closes #184922 X-original-commit: 1f81afa Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

taoeffect · 2024-10-28T18:37:45Z

For folks that aren't aware, there is a Use Google Services for Push Messaging option under brave://settings/privacy (set to OFF by default) which, when enabled, may resolve items which are trying to use GCM

Note, when enabling this setting Brave initiates an odd connection to Google over a non-443 port:

EDIT: seems like a port that's used for a variety of things: https://support.google.com/work/android/answer/10513641?hl=en

Relevant for this issue:

Allows mobile devices to connect to FCM when an organization firewall is present on the network. (see details here)

andradei · 2024-11-04T15:40:21Z

@taoeffect Good catch, thanks for sharing.

A known issue in Brave (brave/brave-browser#2362 (comment)) prevents push notifications unless "Use Google Services for Push Messaging" is enabled in settings. Before this commit, attempting to enable desktop notifications in Brave resulted in a traceback. This commit handles the failure by displaying an error message and suggesting enabling Google Services when using Brave. task-4191214 closes odoo#183968 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Brave-Matt added bug needs-investigation A bug not 100% confirmed/fixed webcompat/not-shields-related Sites are breaking because of something other than Shields. labels Dec 5, 2018

NejcZdovc added this to the 1.x Backlog milestone Dec 5, 2018

Brave-Matt mentioned this issue Dec 13, 2018

Push notifications broken in brave-core #2301

Closed

rebron modified the milestone: 1.x Backlog Feb 7, 2019

bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 5, 2019

Brave-Matt changed the title ~~Desktop notifications from Youtube do not function~~ Desktop notifications do not always function May 6, 2019

bsclifton assigned simonhong May 6, 2019

bsclifton added the blocked label May 13, 2019

bsclifton unassigned simonhong May 13, 2019

bsclifton mentioned this issue May 14, 2019

Build a replacement for GCM/FCM (used for Desktop notifications) #4431

Closed

bsclifton removed the needs-investigation A bug not 100% confirmed/fixed label May 14, 2019

Atovange mentioned this issue Oct 16, 2024

[FIX] mail: better push notifications error handling odoo/odoo#183968

Closed

fw-bot mentioned this issue Oct 18, 2024

[FW][FIX] mail: better push notifications error handling odoo/odoo#184394

Closed

fw-bot mentioned this issue Oct 23, 2024

[FW][FIX] mail: better push notifications error handling odoo/odoo#184895

Closed

fw-bot mentioned this issue Oct 23, 2024

[FW][FIX] mail: better push notifications error handling odoo/odoo#184922

Closed

fw-bot mentioned this issue Oct 23, 2024

[FW][FIX] mail: better push notifications error handling odoo/odoo#184935

Closed

diracdeltas mentioned this issue Oct 28, 2024

Desktop push notifications don't work #41930

Closed

6 tasks

andradei mentioned this issue Nov 4, 2024

🐛 BUG: Can't subscribe to squad dailydotdev/daily#1558

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Desktop push notifications do not always function (twitter, reddit, etc) #2362

Desktop push notifications do not always function (twitter, reddit, etc) #2362

Brave-Matt commented Dec 5, 2018 •

edited by bsclifton

Loading

Brave-Matt commented Dec 13, 2018

Brave-Matt commented Mar 29, 2019

Brave-Matt commented Apr 2, 2019

Brave-Matt commented Apr 4, 2019

Brave-Matt commented Apr 9, 2019

felschr commented Apr 9, 2019

mrdavey commented May 1, 2019

Brave-Matt commented May 6, 2019

bbondy commented May 6, 2019

simonhong commented May 10, 2019 •

edited

Loading

simonhong commented May 13, 2019 •

edited

Loading

Brave-Matt commented May 14, 2019 •

edited

Loading

WorldLanguages commented Jun 24, 2019

snowbound commented Jun 24, 2019

simonhong commented Jun 26, 2019 •

edited

Loading

RealAlphabet commented Jul 17, 2024 •

edited

Loading

taoeffect commented Oct 28, 2024 •

edited

Loading

andradei commented Nov 4, 2024

Desktop push notifications do not always function (twitter, reddit, etc) #2362

Desktop push notifications do not always function (twitter, reddit, etc) #2362

Comments

Brave-Matt commented Dec 5, 2018 • edited by bsclifton Loading

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release:

Website problems only:

Additional Information

Brave-Matt commented Dec 13, 2018

Brave-Matt commented Mar 29, 2019

Brave-Matt commented Apr 2, 2019

Brave-Matt commented Apr 4, 2019

Brave-Matt commented Apr 9, 2019

felschr commented Apr 9, 2019

mrdavey commented May 1, 2019

Brave-Matt commented May 6, 2019

bbondy commented May 6, 2019

simonhong commented May 10, 2019 • edited Loading

simonhong commented May 13, 2019 • edited Loading

Brave-Matt commented May 14, 2019 • edited Loading

WorldLanguages commented Jun 24, 2019

snowbound commented Jun 24, 2019

simonhong commented Jun 26, 2019 • edited Loading

RealAlphabet commented Jul 17, 2024 • edited Loading

taoeffect commented Oct 28, 2024 • edited Loading

andradei commented Nov 4, 2024

Brave-Matt commented Dec 5, 2018 •

edited by bsclifton

Loading

simonhong commented May 10, 2019 •

edited

Loading

simonhong commented May 13, 2019 •

edited

Loading

Brave-Matt commented May 14, 2019 •

edited

Loading

simonhong commented Jun 26, 2019 •

edited

Loading

RealAlphabet commented Jul 17, 2024 •

edited

Loading

taoeffect commented Oct 28, 2024 •

edited

Loading