Upgrade from Chromium 120 to Chromium 121.

[mkarolin]

Upgrade from Chromium 120 to Chromium 121

https://chromium.googlesource.com/chromium/src/+log/120.0.6099.56..121.0.6156.3/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

• Tab strip looks correct (vertical and horizontal)
• Check that channel name is displayed correctly in brave://version (Beta, Nightly)
• Tor Use Bridges setting works
• HTTP -> HTTPS upgrade works
• Rewards, Bookmarks, VPN, Wallet buttons in the toolbar look correctly
• Tor works with a proxy set
• Sidebar items and buttons look correctly
• Web discovery info bar looks correctly
• Verify that "Copy link to text" menu item is not shown in context menu
• Save As is shown in regular and OTR profiles when the setting is turned on
• brave://about shows
• Shields: script blocking and temporarily blocking works
• New tab button looks correctly
• Settings UI cookies page (changed)
• Settings UI security page looks correctly

iOS Affected areas:
TBD

Android Affected areas:

• Lifetime options (double check they work)
• Widevine support (double check it works as expected)
• NTP layout (double there is no regression on NTP)
• New bookmarks UI
• New UI for switches in main menu
• Double check this issue is not happening (Page error when searching from google homepage #23433)

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.63.120 Chromium: 121.0.6167.57 (Official Build) nightly (64-bit)
-- | --
Revision | 7083ae546bb18eb8d8de3c15d6c6e5f5803f45e1
OS | Windows 10 Version 22H2 (Build 19045.3930)

• Encountered [CR121] - New tab button (+) is misaligned on upgrade from C120 -> C121 and in new install as well #35300
• Logged A small gap (towards the left) between the edge and the header bar in an upgraded profile #35374
• Logged Background sync permission content settings image is not shown in the site settings page #35372
• Logged Unable to delete the cookies from the Allowed to use 3rd party cookies list when a profile is upgraded from CR120 to CR121 #35376
• Logged CR121 - Cookies settings are not in sync between brave://settings/cookies and brave://settings/shields settings pages #35415
• Logged CR121 - All extensions text is shown under brave://extensions/ when no extension are installed/imported #35437

Tab strip looks correct (vertical and horizontal)_PASSED

Horizontal Tabs

• Confirm that the tab strip looks good in a Card hover mode
• Confirm that the tab strip looks good in a Card mode`
• Confirm that the tab strip looks good in a Tooltip mode

Card hover mode

Card with Preview hover mode

Tooltip hover mode

Vertical Tabs

• Confirm that the tab strip looks good in a Card hover mode
• Confirm that the tab strip looks good in a Card mode`
• Confirm that the tab strip looks good in a Tooltip mode

Card hover mode

Card with Preview hover mode

Tooltip hover mode

Check that channel name is displayed correctly in brave://version (Beta, Nightly)_PASSED

• Confirmed that channel name looks correct in nightly build via brave://version/
• Confirmed that channel name looks correct in nightly build via brave://settings/help

Example	Example

Tor Use Bridges setting works_PASSED

1. Clean profile 1.63.x CR 121 build
2. Open brave://settings/privacy
3. Make sure Select a built-in bridge is selected and obfs4 is populated in the dropdown
4. Click on Apply changes
5. Ensured that the following domains opened in a Tor window without issues:
   • brave.com
   • duckduckgo.com
   • https://duckduckgogg42xjoc72x3sjasowoarfbgcmvfimaftt6twagswzczad.onion/
   • check.torproject.org (ensured that hard refreshing gets a new circuit/IP)

Use bridges	Example	Example	Example	Example

6. Confirmed the following sites opened via "Open in Tor" button and navigated to .onion URL:
   • brave.com --> https://brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/
   • mail.protonmail.com --> https://protonmailrmez3lotccipshtkleegetolb73fuirgj7r4o4vfu7ozyd.onion/

Example	Example

Example	Example

7. Close the TOR window and disable Use Bridges settings and click on Apply Changes

Example	Example

8. Repeat the steps 5 and 6 and ensure that the TOR network is connected successfully

HTTP -> HTTPS upgrade works_PASSED

Case 1_PASSED

• Confirmed that visiting http://https-everywhere.badssl.com automatically upgrades from HTTP --> HTTPS
• Confirmed that visiting http://https-everywhere.badssl.com doesn't upgrade to HTTPS when shields are disabled
• Confirmed that http://https-everywhere.badssl.com auto-upgraded to HTTPS once the shields is re-enabled
• Confirmed that http://https-everywhere.badssl.com doesn't upgrade to HTTPS when Connections upgrade to HTTPS was disabled
• Confirmed that http://https-everywhere.badssl.com auto-upgraded to HTTPS once Connections upgrade to HTTPS has been enabled

Example	Example	Example	Example

Case 2_PASSED

Default - Upgrade connections to HTTPS, Standard - PASSED

1. installed 1.63.x CR121 build
2. launched Brave
3. confirmed Upgrade connections to HTTPS is set to Standard in brave://settings/shields
4. loaded http://insecure.arthuredelstein.net
5. loaded http://http.badssl.com
6. loaded http://upgradable.arthuredelstein.net
7. opened a New Private Window with Tor and loaded each of the above

default	insecure.arthuredelstein.net	http.badssl.com	upgradable.arthuredelstein.net

Tor

insecure.arthuredelstein.net	http.badssl.com	upgradable.arthuredelstein.net

Upgrade connections to HTTPS, Strict - PASSED

1. installed 1.63.x CR121
2. launched Brave
3. changed Upgrade connections to HTTPS to Strict in brave://settings/shields
4. loaded http://insecure.arthuredelstein.net
5. loaded http://http.badssl.com
6. loaded http://upgradable.arthuredelstein.net
7. opened a New Private Window with Tor and loaded each of the above

Upgrade connections, Strict	insecure.arthuredelstein.net	http.badssl.com	upgradable.arthuredelstein.net

Tor

insecure.arthuredelstein.net	http.badssl.com	upgradable.arthuredelstein.net

Upgrade connections to HTTPS, Disabled - PASSED

1. installed 1.63.x CR121
2. launched Brave
3. changed Upgrade connections to HTTPS to Disabled in brave://settings/shields
4. loaded http://insecure.arthuredelstein.net
5. loaded http://http.badssl.com
6. loaded http://upgradable.arthuredelstein.net
7. opened a New Private Window with Tor and loaded each of the above

Upgrade connections, Disabled	insecure.arthuredelstein.net	http.badssl.com	upgradable.arthuredelstein.net

Tor

insecure.arthuredelstein.net	http.badssl.com	upgradable.arthuredelstein.net

Rewards, Bookmarks, VPN, Wallet buttons in the toolbar look correctly_PASSED

Default settings/enabled

• Confirm that the Rewards, Bookmarks, VPN and Wallet settings are enabled by default via brave://settings/appearance
• Confirmed that the Rewards, Bookmarks, VPN and Wallet buttons are shown correctly in the toolbar
• Confirmed that click on each button works as expected

When the settings are disabled

• Disable Rewards, Bookmarks, VPN and Wallet settings via brave://settings/appearance
• Confirmed that the Rewards, Bookmarks, VPN and Wallet buttons are not visible in the toolbar
  

Tor works with a proxy set_PASSED

Tor works with Proxy

To configure the Cloudflare DNS settings on Windows 10, I have followed the following steps:

1. Open Start.
2. Search for Control Panel
3. Click on Network and Internet
4. Click on Network and Sharing Center
5. Click on Change Adapter Settings
6. Right-click the active Wi-Fi or Ethernet adapter, and select the Properties option.
7. Select the Internet Protocol Version 4 (TCP/IPv4) option.
8. Click the Properties button.
9. Select the Use the following DNS server addresses option.
10. In the "Preferred DNS server" field, enter this IPv4 address: 1.1.1.1
11. In the "Alternative DNS server" field, enter this IPv4 address: 1.0.0.1
12. Click the OK button.
13. Run nslookup in cmd prompt and ensure that you are using Cloudflare DNS settings
14. Run the cases mentioned below in the Tor works without Proxy and ensure that TOR works fine with the cloudfare proxy

steps 1 to 13	Example	Example	Example	Example

Example	Example

Example	Example

Tor works without Proxy

1. Clean profile 1.63.x CR121 build
2. Ensured that the following domains opened in a Tor window without issues:
   • brave.com
   • duckduckgo.com
   • https://duckduckgogg42xjoc72x3sjasowoarfbgcmvfimaftt6twagswzczad.onion/
   • check.torproject.org (ensured that hard refreshing gets a new circuit/IP)

Example	Example	Example	Example

3. Confirmed the following sites opened via "Open in Tor" button and navigated to .onion URL:
   • brave.com --> https://brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/
   • mail.protonmail.com --> https://protonmailrmez3lotccipshtkleegetolb73fuirgj7r4o4vfu7ozyd.onion/

Example	Example

Example	Example

Sidebar items and buttons look correctly_PASSED

• Confirmed that Sidebar items looks correctly on the sidebar
• Confirmed that click on each item on sidebar works as expected

Web discovery info bar looks correctly_PASSED

• Clean profile 1.63.x CR 121
• Open brave://settings/search
• Confirmed Brave is default search engine in brave://settings/search
• Enter a string "hello" in the URL bar
• Confirmed that Web discovery info bar is shown
• Confirmed that the Web discovery info bar looks correct and all the links/buttons on the info bar works as expected
  

Verify that "Copy link to text" menu item is not shown in context menu_PASSED

• Confirm that "Copy link to text" menu item is NOT shown in the context menu

Save As is shown in regular and OTR profiles when the setting is turned on_PASSED

Save As modal in regular profile

1. installed 1.63.x CR121 build
2. launch Brave
3. Visit https://notepad-plus-plus.org/downloads/
4. Click on Download on any of the file
5. Confirm that Save As modal popup is shown and file is saved under the path which is mentioned in the brave://settings/downloads settings

Save As modal in OTR profile

1. installed 1.63.x CR121 build
2. launch Brave
3. set brave://flags/#brave-request-otr-tab to Enabled
4. visited a request-OTR enrolled site: https://www.ceta.tech.cornell.edu/
5. confirmed that the “would you like OTR mode” interstitial appears
6. clicked Proceed Off-The-Record to go into OTR mode
7. confirmed that the requested page appears, and that there is an info bar at the top of the page describing how to leave OTR mode
8. Visit https://notepad-plus-plus.org/downloads/
9. Click on Download on any of the file
10. Confirm that Save As modal popup is shown and file is saved under the path which is mentioned in the brave://settings/downloads settings

Example	Example

brave://about_PASSED

Clean profile

• Install a standalone version which is behind the public nightly version 1.63.120 Chromium: 121.0.6167.57 and open brave://settings/help and ensured that the correct version is shown
• Confirmed that the channel name nightly is shown correctly
• Confirmed that the correct architecture 64-bit is shown
• Confirmed that the update is available, click on Relaunch and confirmed that brave is updated to public nightly version
• Confirmed that Brave is up to date message is shown as brave is already updated to the public version and latest version from Omaha server is picked up correctly

1.63.120 Chromium: 121.0.6167.57	1.63.121 Chromium: 121.0.6167.57

Upgrade profile

Install two CR120 stand alone installers one after the other and ensure that brave is updated to the correct version

• Install 1.62.86 Chromium: 120.0.6099.35 and confirm version details are shown correctly via brave://version and close the browser
• Install 1.63.119 Chromium: 120.0.6099.217 and confirm version details are shown correctly via brave://version and close the browser
• Confirmed that channel name and architecture is shown correctly

1.62.86 Chromium: 120.0.6099.35	1.63.119 Chromium: 120.0.6099.217

• Open brave://settings/help and ensure that the update is available, click on Relaunch and enure that brave is updated to public nightly version

1.63.119 Chromium: 120.0.6099.217	1.63.121 Chromium: 121.0.6167.57

• Confirmed that the channel name nightly is shown correctly
• Confirmed that the correct architecture 64-bit is shown correctly
• Confirmed that Brave is up to date message is shown as brave is already updated to the public version and latest version from Omaha server is picked up correctly

Shields: script blocking and temporarily blocking works_PASSED

Case 1:

1. Clean profile on Nightly 1.63.124
2. Visit a site where things will be blocked (e.g Buzzfeed.com)
3. See shields onboarding
4. Confirmed that the onboarding is shown on the shield
5. Confirmed the bubble auto dismissed at about 15seconds

Case 2:

1. Clean profile on Nightly 1.63.124
2. Visit a site where things are NOT blocked (e.g Brave.com)
3. See shields onboarding
4. Confirmed that the onboarding is NOT shown on the shield

New tab button looks correctly_PASSED

Clean profile

• Confirmed that click on + new tab opens up the new tab in Regular window
• Confirmed that click on + new tab in PT opens up the new tab in Private window
• Confirmed that click on + new tab in TOR windows opens up the new tab in TOR Private window

Upgrade profle

• Encountered [CR121] - New tab button (+) is misaligned on upgrade from C120 -> C121 and in new install as well #35300
• Confirmed that click on + new tab opens up the new tab in Regular window
• Confirmed that click on + new tab in PT opens up the new tab in Private window
• Confirmed that click on + new tab in TOR windows opens up the new tab in TOR Private window

Settings UI cookies page (changed)_PASSED

• Cookies UI design is changed as part of CR121, In the CR121 build there is no "Block all" cookies settings in brave://settings/cookies, Also the setting Clear cookies and site data when you close all windows is removed as part of chromium 121
• The custom cookies settings are removed from the brave://settings/cookies page
• Currently there is only Allowed to use third-party cookies Add custom cookies sites settings
• Confirmed that user can add custom cookies sites under Allowed to use third-party cookies via Add button
• Confirmed that user can delete the added custom cookies sites by clicking on the trash icon
• Chromium cookies settings and shield settings are not in sync - Logged CR121 - Cookies settings are not in sync between brave://settings/cookies and brave://settings/shields settings pages #35415
• Custom sites added in older profile are not retained in an upgraded CR121 profile - Logged CR 121 - Sites added under Sites that can always use cookies block are not retained in an upgraded profile CR121 #35435
  
• Cookies settings are renamed to Allow third-party cookies and Block third-party cookies as part of CR121
• In a clean profile, open a site A, check the site info and confirm that 3rd party cookies are blocked on the site A, open brave://settings/cookies and change the cookies settings to Allow third-party cookies and then reload the site A check the cookies blocked count forsite A, the cookies blocked count is same, ideally it should not block any cookies on the site when "Allow 3rd party cookies" settings are selected, this issue is happening due to the issue CR121 - Cookies settings are not in sync between brave://settings/cookies and brave://settings/shields settings pages #35415

Settings UI security page looks correctly_PASSED

Clean profile

• Confirmed that the new UI for the secure DNS settings is inherited from chromium 121
• Confirmed that new DNS are added into the Select DNS provider dropdown
• Confirmed that OS dafault (when available) settings is selected by default in the dropdown
• Confirmed that user can set different custom DNS

Disable the Use secure DNS in CR 120 and upgrade the profile to 121

• Install 1.63.119 CR 120 build
• Open brave://settings/security
• Disable Use secure DNS settings
• Upgrade the profile to 1.63.x CR121 build
• Confirmed that the setting remained disabled in an upgraded profile
• Confirm that the text Use secure DNS is replaced by the new chromium text Encrypt the names of sites you visit

1.63.119	1.63.124

Upgrade profile

• Install 1.63.119 CR 120 build
• Open brave://settings/security
• Select cloudfare 1.1.1.1 custom DNS or any other DNS
• Upgrade the profile to 1.63.x CR121 build
• Confirmed that the updated settings cloudfare 1.1.1.1 custom DNS is retained in an upgraded profile

1.63.119	1.63.124

---

Settings comparison

• Confirmed that new settings are added in the Select DNS provider dropdown as part of CR 121 under security Tab
• Security page changes are verified as part of Settings UI security page looks correctly case above
  
• The Cookies and other site data text is renamed to Third-party cookies in brave://settings/privacy page which is same as Chromium CR121
• The brave://settings/cookies page settings and removed and updated as part of CR 121 - Testing on cookies is covered in the case Settings UI cookies page (changed) above.
• Bookmarks Add modal popup is changed as part of CR121
  
• The Brave Rewards settings is removed from the brave://settings left navigation menu and the settings Show Brave Rewards button is added via brave://settings/appearance as part of Brave
  
• The new content settings On-device site data added as part of CR 121
  

Brave startup calls

• Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
• Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile

[Uni-verse]

Verified on Samsung Galaxy Tab S7 using version:

Brave	1.63.124 Chromium: 121.0.6167.57 (Official Build) canary (64-bit) 
Revision	e0864ffae4be8015ad75c2b344ab75c2eefb31a7
OS	Android 13; Build/TP1A.220624.014; 33; REL

Lifetime options

• Ensured that permissions options are shown when initiating call on https://talk.brave.com
• Ensured that permissions are retained in site settings.
• Ensured that selecting until I close this site option will not be retained after closing webpage.
• Ensured that permissions can be reset/removed.

Example	Example	Example	Example

Widevine

• Ensured that widevine videos on amazon prime will play automatically when Widevine DRM is enabled.
• Ensured that prompt is shown when playing content if Widevine is disabled.

Example	Example

NTP Layout

• Ensured NTP-SI are shown every 3rd tab.
• Ensured Brave News peaking card is shown on fresh profile.
• Ensured Brave News feed is shown when users opts in.
• Ensured background images can be toggled via settings.
• Ensured stats can be toggled via settings.
• Ensured switching from private tabs to normal tabs does not cause any issues with layout.
• Ensured top sites are shown by default and can be toggled via settings.
• Ensured top sites can be removed via long press context menu.

Example	Example	Example	Example

New Bookmarks UI

• Verified new bookmark UI when bookmarking pages.
• Verified changing folder when bookmarking.
• Verified creating folder when bookmarking.
• Verified unbookmarking pages works.
• Verified URL is loaded when opening bookmarked page from bookmarks manager.
• Verified deleting bookmark.
• Verified bookmarks are synced to other devices.

Light Mode	Dark Mode	Folder Selection Screen	Addition Screens	Create New Folder	Select New Folder	Bookmark Manager

New UI for switches

• Verified new UI design for switches in main menu
• Verified enabling / disabling switches works.

Encountered: #35335

Example	Example

Double check [Issue](https://github.com//issues/23433)

• Ensured searching on google homepage does not cause page error

Example	Example

[Uni-verse]

Verified on Samsung Galaxy S21 using version:

Brave	1.63.124 Chromium: 121.0.6167.57 (Official Build) canary (64-bit) 
Revision	e0864ffae4be8015ad75c2b344ab75c2eefb31a7
OS	Android 13; Build/TP1A.220624.014; 33; REL

Lifetime options

• Ensured that permissions options are shown when initiating call on https://talk.brave.com
• Ensured that permissions are retained in site settings.
• Ensured that selecting until I close this site option will not be retained after closing webpage.
• Ensured that permissions can be reset/removed.

Example	Example

Widevine

• Ensured that widevine videos on amazon prime will play automatically when Widevine DRM is enabled.
• Ensured that prompt is shown when playing content if Widevine is disabled.

Example	Example

NTP Layout

• Ensured NTP-SI are shown every 3rd tab.
• Ensured Brave News peaking card is shown on fresh profile.
• Ensured Brave News feed is shown when users opts in.
• Ensured background images can be toggled via settings.
• Ensured stats can be toggled via settings.
• Ensured switching from private tabs to normal tabs does not cause any issues with layout.
• Ensured top sites are shown by default and can be toggled via settings.
• Ensured top sites can be removed via long press context menu.

Example	Example	Example

New Bookmarks UI

• Verified new bookmark UI when bookmarking pages.
• Verified changing folder when bookmarking.
• Verified creating folder when bookmarking.
• Verified unbookmarking pages works.
• Verified URL is loaded when opening bookmarked page from bookmarks manager.
• Verified deleting bookmark.
• Verified bookmarks are synced to other devices.

Light Mode	Dark Mode	Folder Selection Screen	Edit	Filter	Bookmarks 1	Bookmarks 2

New UI for switches

• Verified new UI design for switches in main menu
• Verified enabling / disabling switches works.

Encountered: #35335

Example	Example

Double check [Issue](https://github.com//issues/23433)

• Ensured searching on google homepage does not cause page error

Example	Example

[kjozwiak]

Labelling as QA/No & release-notes/exclude in favour of #35382 (comment).