-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Chromium 121.0.6167.57 to Chromium 121.0.6167.75. #35382
Comments
Adding |
The above requires |
Quick overview of the work remaining re: affected areas due to Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #34702 (comment):
Platforms that still need to check/verify the affected areas due to
|
Verified cases below, to be continued with #35493 (comment).
Encountered #35495 while testing (not specific to Chromium 121). Verifying desktop affected areas from #34702 (comment): Tab strip looks correct (vertical and horizontal) - PASSEDHorizontal Tabs
Vertical Tabs
Check that channel name is displayed correctly in brave://version (Nightly, Beta, Release) - PASSED
Tor Use Bridges setting works - PASSED
HTTP -> HTTPS upgrade works - PASSEDCase 1 - PASSED
Case 2 - PASSEDDefault -
|
default |
insecure.arthuredelstein.net |
http.badssl.com |
upgradable.arthuredelstein.net |
---|---|---|---|
Tor
insecure.arthuredelstein.net |
http.badssl.com |
upgradable.arthuredelstein.net |
---|---|---|
Upgrade connections to HTTPS
, Strict
- PASSED
- installed 1.62.x RC build
- launched Brave
- changed
Upgrade connections to HTTPS
toStrict
inbrave://settings/shields
- loaded
http://insecure.arthuredelstein.net
- loaded
http://http.badssl.com
- loaded
http://upgradable.arthuredelstein.net
- opened a
New Private Window with Tor
and loaded each of the above
Upgrade connections, Strict |
insecure.arthuredelstein.net |
http.badssl.com |
upgradable.arthuredelstein.net |
---|---|---|---|
Tor
insecure.arthuredelstein.net |
http.badssl.com |
upgradable.arthuredelstein.net |
---|---|---|
Upgrade connections to HTTPS
, Disabled
- PASSED
- installed 1.62.x RC build
- launched Brave
- changed
Upgrade connections to HTTPS
toDisabled
inbrave://settings/shields
- loaded
http://insecure.arthuredelstein.net
- loaded
http://http.badssl.com
- loaded
http://upgradable.arthuredelstein.net
- opened a
New Private Window with Tor
and loaded each of the above
Upgrade connections, Disabled |
insecure.arthuredelstein.net |
http.badssl.com |
upgradable.arthuredelstein.net |
---|---|---|---|
Tor
insecure.arthuredelstein.net |
http.badssl.com |
upgradable.arthuredelstein.net |
---|---|---|
Rewards, Bookmarks, VPN, Wallet buttons in the toolbar look correctly - PASSED
Default settings/enabled
- Confirm that the
Rewards
,Bookmarks
,VPN
andWallet
settings are enabled by default via brave://settings/appearance - Confirmed that the
Rewards
,Bookmarks
,VPN
andWallet
buttons are shown correctly in the toolbar - Confirmed that click on each button works as expected
Example | Example |
---|---|
When the settings are disabled
- Disable
Rewards
,Bookmarks
,VPN
andWallet
settings via brave://settings/appearance - Confirmed that the
Rewards
,Bookmarks
,VPN
andWallet
buttons are not visible in the toolbar
Example | Example |
---|---|
Tor works with a proxy set - PASSED
Tor works with Proxy
Case 1:
- Launch Brave with
--args --enable-logging=stderr --proxy-server="socks5://localhost:9000"
- Visit
brave.com
---> site doesn't load as expected due to the proxy directing traffic to localhost - Visit
https://brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/
---> site loads since Tor doesn't use the proxy
Example | Example |
---|---|
Case 2:
- Confirm Charles Proxy is set up and launched
- Start Brave with Charles enabled
- Go to
brave.com
in a normal window and confirm that the request is able to be seen in Charles - Open a Tor window
- Navigate to
https://brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/
- Confirm the site loads as expected and is not shown in Charles
Example | Example |
---|---|
Tor works without Proxy
- Clean profile 1.62.x RC
- Ensured that the following domains opened in a Tor window without issues:
- brave.com
- duckduckgo.com
- https://duckduckgogg42xjoc72x3sjasowoarfbgcmvfimaftt6twagswzczad.onion/
- check.torproject.org (ensured that hard refreshing gets a new circuit/IP)
Example | Example | Example | Example | Example |
---|---|---|---|---|
- Confirmed the following sites opened via "Open in Tor" button and navigated to .onion URL:
Example | Example |
---|---|
Example | Example |
---|---|
Labelling the above as |
Minor Chromium bump
https://chromium.googlesource.com/chromium/src/+log/121.0.6167.57..121.0.6167.75?pretty=fuller&n=10000
QA tests:
Additional checks:
The text was updated successfully, but these errors were encountered: