Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR 121 - Sites added under Sites that can always use cookies block are not retained in an upgraded profile CR121 #35435

Open
GeetaSarvadnya opened this issue Jan 19, 2024 · 2 comments
Labels
bug Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #34702
Sites added under Sites that can always use cookies block are not retained in an upgraded profile CR121

Though CR 121 has a new UI design for the custom cookies settings block, the custom cookies sites added under the Sites that can always use cookies block are not retained upon upgrade to CR 121. However, chrome retains the custom cookies sites in an upgraded profile

Steps to Reproduce

  1. Clean profile 1.62.x CR 120 build
  2. Open brave://settings/cookies
  3. Add few sites under Sites that can always use cookies block
  4. Upgrade the profile to 1.64.x CR 121 build
  5. Added cookies are not retained in the Allowed to use third-party cookies block

Actual result:

Sites added under Sites that can always use cookies block are not retained in an upgraded profile CR121

1.62.x 1.64.x
image image

Expected result:

Sites added under Sites that can always use cookies block should be retained in an upgraded profile CR121 and sites should show under Allowed to use third-party cookies block

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.64.2 Chromium: 121.0.6167.57 (Official Build) nightly (64-bit)
Revision 090e22f
OS Windows 10 Version 22H2 (Build 19045.3930)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @rebron @bridiver @ShivanKaul @mkarolin

@GeetaSarvadnya GeetaSarvadnya changed the title Sites added under Sites that can always use cookies block are not retained in an upgraded profile CR121 CR 121 - Sites added under Sites that can always use cookies block are not retained in an upgraded profile CR121 Jan 19, 2024
@rebron
Copy link
Collaborator

rebron commented Feb 6, 2024

cc: @goodov

@rebron rebron added priority/P1 A very extremely bad problem. We might push a hotfix for it. priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Feb 6, 2024
@goodov
Copy link
Member

goodov commented Feb 6, 2024

This is Chromium change, apparently they expects users to click on Site settings icon in omnibox and configure Cookies from there from now on. Should we restore the good-old Cookies page or should we implement a separate page that can also control Shields and be clear about all cookies exceptions - that's the question for our product team.

@rebron rebron moved this to P3 backlog in Settings May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes
Projects
Status: P3 backlog
Development

No branches or pull requests

3 participants