Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave News: new regions enable pref by default (fr_FR and de_DE) #32416

Closed
petemill opened this issue Aug 21, 2023 · 5 comments · Fixed by brave/brave-core#20197
Closed

Brave News: new regions enable pref by default (fr_FR and de_DE) #32416

petemill opened this issue Aug 21, 2023 · 5 comments · Fixed by brave/brave-core#20197

Comments

@petemill
Copy link
Member

petemill commented Aug 21, 2023

Add fr_FR and de_DE to the list of locales that will result in the user having News enabled by default.

Test Plan

  1. Set default region and language in OS to fr_FR or de_DE
  2. Run fresh profile
  3. Verify locale at brave://rewards-internals/ and click the "Ad diagnostics", check locale field is the intended one.
  4. Confirm Brave News shows by default on the NTP

Example/Template for STR/Cases can be used from brave/brave-core#20197 (comment). Please feel free to add any other checks/verifications.

image
@petemill petemill added OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 21, 2023
@petemill petemill self-assigned this Aug 21, 2023
@brave-builds brave-builds added this to the 1.60.x - Nightly milestone Sep 19, 2023
@petemill petemill changed the title News new regions enable pref by default Brave News: new regions enable pref by default (fr_FR and de_DE) Sep 25, 2023
@kjozwiak kjozwiak added feature/brave-news formerly brave-today and removed OS/Android Fixes related to Android browser functionality labels Sep 27, 2023
@kjozwiak
Copy link
Member

Removing OS/Android as the above won't be verifiable till #33267 is addressed. Once #33267 is fixed, we'll run through the same STR/Cases that were completed via brave/brave-core#20197 (comment).

@kjozwiak
Copy link
Member

The above requires 1.58.134 or higher for 1.58.x verification 👍

@stephendonner stephendonner added QA/Test-All-Platforms QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 28, 2023
@stephendonner
Copy link

stephendonner commented Sep 28, 2023

Verification PASSED using

Brave | 1.58.134 Chromium: 117.0.5938.140 (Official Build) (x86_64)
-- | --
Revision | b0942733988798287d53c996e097f756d614a059
OS | macOS Version 14.1 (Build 23B5046f)

fr_FR - PASSED

Steps:

  1. set my macOS region & language to France and fr_FR, respectively
  2. installed 1.58.134
  3. launched Brave
  4. confirmed French (France) language in brave://settings/languages
  5. opened brave://rewards-internals/
  6. clicked on the Ad diagnostics tab
  7. confirmed Locale: fr-FR string
  8. opened a new-tab page
  9. opted-in to Brave News
  10. confirmed locale-specific sources displayed
example example example example example example
Capture d’écran 2023-09-28 à 02 15 16 Capture d’écran 2023-09-28 à 02 17 07 Capture d’écran 2023-09-28 à 02 09 45 Capture d’écran 2023-09-28 à 02 09 58 Capture d’écran 2023-09-28 à 02 10 04 Capture d’écran 2023-09-28 à 02 10 15

de_DE - PASSED

Steps:

  1. set my macOS region & language to Germany and de_DE, respectively
  2. installed 1.58.134
  3. launched Brave
  4. confirmed German (Germany) language in brave://settings/languages
  5. opened brave://rewards-internals/
  6. clicked on the Ad diagnostics tab
  7. confirmed Locale: de-DE string
  8. opened a new-tab page
  9. opted-in to Brave News
  10. confirmed locale-specific sources displayed
example example example example example example
Bildschirmfoto 2023-09-28 um 02 22 05 Bildschirmfoto 2023-09-28 um 02 22 38 Bildschirmfoto 2023-09-28 um 02 22 53 Bildschirmfoto 2023-09-28 um 02 24 21 Bildschirmfoto 2023-09-28 um 02 24 26 Bildschirmfoto 2023-09-28 um 02 24 31

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 28, 2023
@btlechowski
Copy link

Verification PASSED

Brave 1.58.134 Chromium: 117.0.5938.140 (Official Build) (64-bit)
Revision b0942733988798287d53c996e097f756d614a059
OS Linux

fr_FR - PASSED

Steps:

  1. set my macOS region & language to France and fr_FR, respectively
  2. installed 1.58.134
  3. launched Brave
  4. confirmed French (France) language in brave://settings/languages
  5. opened brave://rewards-internals/
  6. clicked on the Ad diagnostics tab
  7. confirmed Locale: fr-FR string
  8. opened a new-tab page
  9. opted-in to Brave News
  10. confirmed locale-specific sources displayed
image image image image

de_DE - PASSED

Steps:

  1. set my macOS region & language to Germany and de_DE, respectively
  2. installed 1.58.134
  3. launched Brave
  4. confirmed German (Germany) language in brave://settings/languages
  5. opened brave://rewards-internals/
  6. clicked on the Ad diagnostics tab
  7. confirmed Locale: de-DE string
  8. opened a new-tab page
  9. opted-in to Brave News
  10. confirmed locale-specific sources displayed
image image image image

@kjozwiak
Copy link
Member

Verification PASSED on Win 10 x64 using the following build(s):

fr-FR Cases

Brave | 1.58.135 Chromium: 117.0.5938.140 (Build officiel) (64 bits)
-- | --
Révision | 325e8592cad8c6badb656cab238b722ae46bf7bc
Système d'exploitation | Windows 10 Version 22H2 (Build 19045.3516)

Using the STR/Cases and information via #32416 (comment), ensured that the Brave News feed was available via NTP as per the following:

Example Example Example Example Example
image image image image image

de-DE Cases

Brave | 1.58.135 Chromium: 117.0.5938.140 (Offizieller Build) (64-Bit)
-- | --
Überarbeitung | 325e8592cad8c6badb656cab238b722ae46bf7bc
Betriebssystem | Windows 10 Version 22H2 (Build 19045.3516)

Using the STR/Cases and information via #32416 (comment), ensured that the Brave News feed was available via NTP as per the following:

Example Example Example Example Example
image image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment