-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave News: new regions enable pref by default (fr_FR and de_DE) #32416
Comments
Removing |
The above requires |
Verification
fr_FR -
|
de_DE - PASSED
Steps:
- set my macOS region & language to
Germany
andde_DE
, respectively - installed
1.58.134
- launched Brave
- confirmed
German (Germany)
language inbrave://settings/languages
- opened
brave://rewards-internals/
- clicked on the
Ad diagnostics
tab - confirmed
Locale: de-DE
string - opened a new-tab page
- opted-in to Brave News
- confirmed locale-specific sources displayed
Verification PASSED on
|
Example |
Example |
Example |
Example |
Example |
---|---|---|---|---|
de-DE Cases
Brave | 1.58.135 Chromium: 117.0.5938.140 (Offizieller Build) (64-Bit)
-- | --
Überarbeitung | 325e8592cad8c6badb656cab238b722ae46bf7bc
Betriebssystem | Windows 10 Version 22H2 (Build 19045.3516)
Using the STR/Cases and information via #32416 (comment), ensured that the Brave News
feed was available via NTP as per the following:
Example |
Example |
Example |
Example |
Example |
---|---|---|---|---|
Add
fr_FR
andde_DE
to the list of locales that will result in the user having News enabled by default.Test Plan
locale
field is the intended one.Example/Template for STR/Cases can be used from brave/brave-core#20197 (comment). Please feel free to add any other checks/verifications.
The text was updated successfully, but these errors were encountered: