Brave News button in new tab page not shown (before opt-in) for (es_AR) & (de_DE) locales

[MadhaviSeelam]

Description

For a new profile in Argentina & Germany locales, Brave news button (and Turn on News button) is not shown in the NTP when scrolled down. Hence user will not be able to opt-in to news via Turn on News card. However, user is able to enable news via Customize button. Previously this issue was verified via #33251 & #32416. Brazil (Portuguese) & Japan locales are working as expected, i.e. News button is shown before opt-in.

Steps to Reproduce

Steps:

1. set my Win region & language to Argentina and `Espanol Argentina¨, respectively
2. installed 1.65.118
3. launched Brave
4. confirmed espanol language in brave://settings/languages
5. opened a new-tab page

Actual result:

"News" button (before opt-in) is not shown. Same issue encountered with Germany as well.

Argentina

newsAR.mp4

Germany

gerrman.mp4

Expected result:

News button should be shown as in Brazil(Portuguese) locale

portugal.mp4

Reproduces how often:

Easily

Brave version (brave://version info)

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@LorenzoMinto
cc: @rebron @brave/qa-team

[LorenzoMinto]

@fallaciousreasoning @petemill could it be something related to the new feed UI? The issues above were verified on the previous feed.

@MadhaviSeelam I would expect this issue to be also present in the fr_FR locale.

[fallaciousreasoning]

Weird - those locales all look like they're enabled by default

[fallaciousreasoning]

Interesting - it shows up for me in es_AR and de_DE - how were you setting the language?

Looking at the code, it makes the decision of whether or not to show the hint button on the NTP at first launch of a profile, and it isn't updated afterwards (even if the locale changes).

Does it work if you set the language explicitly on the command line?

LANGUAGE=es_AR brave --user-data-dir=argentina

[MadhaviSeelam]

@fallaciousreasoning -

• tried setting AR locale via Powershell in Win and News button is shown but I am not sure if that is correct
• Also tried browser language to espanol(Argentina) via brave://settings/languages and I see Noticias button.

example	example

• However, if set the language & region via Windows Settings, News button is not shown.

example	example	example	example

[MadhaviSeelam]

@LorenzoMinto

@fallaciousreasoning @petemill could it be something related to the new feed UI? The issues above were verified on the previous feed.

@MadhaviSeelam I would expect this issue to be also present in the fr_FR locale.

No issues with Fr_FR locale.

example	example	example

[LorenzoMinto]

Weird - those locales all look like they're enabled by default

@fallaciousreasoning just noticed in the screenshots "de_DE" and "es_AR" are not comma separated. Would this cause an error? Just checked in brave-core and this is still the case.

[LorenzoMinto]

just in case brave/brave-core#25390

[kjozwiak]

The above requires 1.69.162 or higher for 1.69.x verification 👍

[fallaciousreasoning]

just noticed in the screenshots "de_DE" and "es_AR" are not comma separated. Would this cause an error? Just checked in brave-core and this is still the case.

Yes - yes it would 😆 - if there are no commas C++ treats it as a concatenation, so the locale would've been `"de_DEes_AR". Nice catch @LorenzoMinto

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.69.162 Chromium: 128.0.6613.120 (Official Build) (64-bit)
-- | --
Revision | e534755d4eb5ad363bb357735e614be1c6421e02
OS | Windows 10 Version 22H2 (Build 19045.4780)

Reproduced the issue on 1.65.118

Example	Example

Upgraded the profile to 1.69.162 and ensured that Turn on Brave News news welcome screen is shown on the NTP

• Confirmed that user can enable Brave News via NTP by clicking on Turn on Brave News on news welcome screen
• Confirmed that user can view brave news feeds

Example	Example	Example	Example	Example