Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Attention value in auto-contribute table when Allow contribution to non-verified sites is changed #3015

Closed
btlechowski opened this issue Jan 18, 2019 · 2 comments · Fixed by brave/brave-core#1457

Comments

@btlechowski
Copy link

Steps to Reproduce

test case 1

  1. Clean profile
  2. Enable rewards
  3. Go to a non-verified publisher (interia.pl) and wait on the page for 10s
  4. Turn off Allow contribution to non-verified sites in auto-contribute settings
  5. Go to a verified publisher (https://kjozwiak.github.io/) and wait on the page for 10s
  6. Turn on Allow contribution to non-verified sites

test case 2

  1. Clean profile
  2. Enable rewards
  3. Go to a non-verified publisher (interia.pl) and wait on the page for 10s
  4. Go to a verified publisher (https://kjozwiak.github.io/) and wait on the page for 10s
  5. Turn off Allow contribution to non-verified sites in auto-contribute settings

Actual result:

test case 1:
image

test case 2:
image

Expected result:

On Allow contribution to non-verified sites change, the values are recalculated

Reproduces how often:

always

Brave version (brave://version info)

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 7

cc @brave/legacy_qa @NejcZdovc

@LaurenWags
Copy link
Member

Reproduced on macOS

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Mac OS X

@btlechowski
Copy link
Author

btlechowski commented Feb 25, 2019

Verification passed on

Brave 0.61.37 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

Used STR from the description. Also check publishers on youtube and twitch.

Verification passed on

Brave 0.61.41 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Linux mint
  • Verified STR from the description. Also, check publishers on youtube and twitch.

Verified passed with

Brave 0.61.45 Chromium: 73.0.3683.39 (Official Build) beta(64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Mac OS X
  • Verified STR from description
  • Tested regular sites, youtube, and twitch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment