Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clicking anywhere on the same line as 'Bookmarks' toggles Bookmark Sync on/off #2574

Closed
LaurenWags opened this issue Dec 14, 2018 · 1 comment · Fixed by brave/brave-core#1193

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Dec 14, 2018

Test plan

See brave/brave-core#1193

Description

If you click anywhere on the same line as 'Bookmarks', Bookmark sync is toggled on/off.

Steps to Reproduce

  1. Sync two devices
  2. On brave://sync page, click somewhere to the right of the word 'Bookmarks' on the same line.

Actual result:

entirelineclickable

Expected result:

Just toggle itself should be clickable

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

@LaurenWags LaurenWags added this to the 1.x Backlog milestone Dec 14, 2018
@cezaraugusto cezaraugusto self-assigned this Dec 17, 2018
@bbondy bbondy added the priority/P4 Planned work. We expect to get to it "soon". label Dec 20, 2018
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 1, 2019
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 2, 2019
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 3, 2019
@cezaraugusto cezaraugusto modified the milestones: 1.x Backlog, 0.61.x - Nightly Jan 4, 2019
@srirambv
Copy link
Contributor

srirambv commented Jan 8, 2019

Verification passed on

Brave | 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)

Revision | 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS | Linux

2574

Verified passed with

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

Verification passed on

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants