Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Filecoin Ledger Integration to untrusted iframe #24449

Closed
nvonpentz opened this issue Aug 4, 2022 · 3 comments · Fixed by brave/brave-core#14794 or brave/brave-core#14869
Closed

Move Filecoin Ledger Integration to untrusted iframe #24449

nvonpentz opened this issue Aug 4, 2022 · 3 comments · Fixed by brave/brave-core#14794 or brave/brave-core#14869
Assignees
@cypt4
Labels
feature/web3/wallet/filecoin feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA/Yes release-notes/include security
Milestone
1.44.x - Release

Comments

@nvonpentz
Copy link
Member

Implementation should be similar to brave/brave-core#14373. The main parts are -

  • Modify the keyring class send commands to the untrusted iframe via LedgerTrustedMessagingTransport by inheriting from LedgerBridgeKeyring
  • Define command handlers on a FilecoinLedgerUntrustedMessagingTransport class that inherits LedgerUntrustedMessagingTransport and instantiate it in ledger.ts.
@nvonpentz nvonpentz added OS/Android Fixes related to Android browser functionality OS/Desktop feature/web3/wallet Integrating Ethereum+ wallet support security labels Aug 4, 2022
@yrliou yrliou added this to Web3 Aug 4, 2022
@yrliou yrliou added the priority/P2 A bad problem. We might uplift this to the next planned release. label Aug 5, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Aug 12, 2022
cypt4 added a commit to brave/brave-core that referenced this issue Aug 12, 2022
@cypt4
Move filecoin hw ledger connection to untrusted iframe
811c264 
Fixes brave/brave-browser#24449
@cypt4 cypt4 mentioned this issue Aug 24, 2022
Merged
25 tasks
cypt4 added a commit to brave/brave-core that referenced this issue Aug 24, 2022
@cypt4
Move filecoin hw ledger connection to untrusted iframe
5f7e4d9 
Fixes brave/brave-browser#24449
cypt4 added a commit to brave/brave-core that referenced this issue Aug 25, 2022
@cypt4
Move filecoin hw ledger connection to untrusted iframe
34f87b8 
Fixes brave/brave-browser#24449
@cypt4 cypt4 added the QA/Yes label Aug 25, 2022
Repository owner moved this from Backlog to Done in Web3 Aug 28, 2022
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Aug 28, 2022
cypt4 added a commit to brave/brave-core that referenced this issue Aug 29, 2022
@cypt4
Move filecoin hw ledger connection to untrusted iframe
ce24e89 
Fixes brave/brave-browser#24449

Review fix
@cypt4 cypt4 mentioned this issue Aug 29, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Sep 2, 2022

The above requires 1.44.74 or higher for 1.44.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Sep 6, 2022

Removing OS/Android label as there is no support for it on Android yet

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Sep 6, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.44.97 Chromium: 106.0.5249.55 (Official Build) (64-bit)
Revision 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS Linux
24449.mp4

@kjozwiak kjozwiak mentioned this issue Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
feature/web3/wallet/filecoin feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA/Yes release-notes/include security
Projects
Web3
Archived in project
Milestone
1.44.x - Release
6 participants
@kjozwiak @yrliou @nvonpentz @srirambv @brave-builds @cypt4