Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rewards verification state changes to Event Logs tab of brave://rewards-internals for Gemini and bitFlyer #24112

Closed
LaurenWags opened this issue Jul 18, 2022 · 2 comments · Fixed by brave/brave-core#14320

Comments

@LaurenWags
Copy link
Member

Description

While testing #23682 noticed that rewards verification state changes are only logged on the "Event logs" tab of brave://rewards-internals for Uphold, not for Gemini or bitFlyer.

Per discussion with @Miyayes @szilardszaloki this is something we want to consider adding.

Steps to Reproduce

  1. Clean profile, staging env
  2. Enable Rewards
  3. Link KYC'd Uphold account
  4. Look at brave://rewards-internals Event Logs tab, see line for NOT_CONNECTED --> PENDING and then PENDING --> VERIFIED rewards verification state change
  5. Repeat for Gemini or bitFlyer

Actual result:

Gemini and bitFlyer don't list the rewards verification state changes on Event Logs tab

Expected result:

Like the below which exists for Uphold

uphold example

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.42.68 Chromium: 103.0.5060.114 (Official Build) beta (x86_64)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS macOS Version 12.4 (Build 21F79)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@Miyayes Miyayes changed the title add rewards verification state changes to Event Logs tab of brave://rewards-internals Add Rewards verification state changes to Event Logs tab of brave://rewards-internals for Gemini and bitFlyer Jul 18, 2022
@Miyayes Miyayes added feature/rewards/Gemini feature/rewards/bitFlyer OS/Android Fixes related to Android browser functionality labels Jul 18, 2022
@Miyayes Miyayes added the priority/P4 Planned work. We expect to get to it "soon". label Jul 22, 2022
@brave-builds brave-builds added this to the 1.44.x - Nightly milestone Jul 27, 2022
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 2, 2022
@LaurenWags
Copy link
Member Author

LaurenWags commented Sep 2, 2022

Verified with

Brave | 1.44.73 Chromium: 105.0.5195.68 (Official Build) beta (x86_64)
-- | --
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | macOS Version 12.5.1 (Build 21G83)
Gemini - PASSED
  1. Clean profile (restart to pull griffin seed)
  2. Enable Rewards
  3. Link Gemini account
  4. Navigate to Gemini and revoke authorization
  5. Once this is picked up, manually disconnect from Gemini

Confirmed verification state changes from the above were displayed on the "Event logs" tab of brave://rewards-internals:

Gemini
bitFlyer - PASSED

pre-req: be set to Japan region

  1. Clean profile (restart to pull griffin seed)
  2. Enable Rewards
  3. Link bitFlyer account
  4. Wait 7+ minutes, attempt a tip, you will be disconnected
  5. Manually disconnect from bitFlyer

Confirmed verification state changes from the above were displayed on the "Event logs" tab of brave://rewards-internals:

bitFlyer
Brave | 1.44.79 Chromium: 105.0.5195.102 (Official Build) beta (x86_64)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | macOS Version 12.5.1 (Build 21G83)
Uphold - PASSED
  1. Clean profile (restart to pull griffin seed)
  2. Enable Rewards
  3. Link Uphold account
  4. Navigate to Uphold and revoke authorization
  5. Once this is picked up, manually disconnect from Uphold

Confirmed verification state changes from the above were displayed on the "Event logs" tab of brave://rewards-internals:

Uphold

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 9, 2022
@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 5G & Samsung Galaxy Tab S7 using

Brave	1.44.95 Chromium: 106.0.5249.40 (Official Build) (64-bit) 
Revision	fab1d91915d2722d6339aaa7f4e9ce44f1e9b103-refs/branch-heads/5249@{#442}
OS	Android 12; Build/SP1A.210812.016

Test Plan: #24112 (comment)

  • Verified verification state changes are logged in brave://rewards-internals for Uphold, Gemini and bitFlyer
Uphold Gemini bitFlyer
screenshot-1663791689991 screenshot-1663791868700 screenshot-1663792152025
Screen Shot 2022-09-21 at 3 52 08 PM Screen Shot 2022-09-21 at 3 58 46 PM Screen Shot 2022-09-21 at 4 16 47 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment