Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify_url should be removed. #23682

Closed
szilardszaloki opened this issue Jun 24, 2022 · 4 comments · Fixed by brave/brave-core#13956
Closed

verify_url should be removed. #23682

szilardszaloki opened this issue Jun 24, 2022 · 4 comments · Fixed by brave/brave-core#13956
Assignees
@szilardszaloki
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.42.x - Release

Comments

@szilardszaloki
Copy link
Contributor

Description

https://github.com/brave/internal/issues/829
@szilardszaloki szilardszaloki added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality OS/Desktop labels Jun 24, 2022
@szilardszaloki szilardszaloki self-assigned this Jun 24, 2022
@szilardszaloki szilardszaloki mentioned this issue Jun 25, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.42.x - Nightly milestone Jun 29, 2022
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 15, 2022
@LaurenWags
Copy link
Member

LaurenWags commented Jul 15, 2022 •
edited
Loading

Verified with

Brave | 1.42.68 Chromium: 103.0.5060.114 (Official Build) beta (x86_64)
-- | --
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | macOS Version 12.4 (Build 21F79)

Verified test plan from brave/brave-core#13956 (comment)

Logged #24112 for Gemini and bitFlyer not showing rewards verification state changes on brave://rewards-internals Event logs tab.

Uphold - PASSED
Scenario 1 - Verify from brave://rewards - PASSED
  1. Clean profile, staging env
  2. Enable Rewards
  3. Navigate to brave://rewards
  4. Select "Unverified"
  5. Follow prompts and verify with custodian

Confirmed able to verify with Uphold from brave://rewards page:

Example Example Example
a b c
Scenario 2 - Verify from rewards panel - PASSED
  1. Clean profile, staging env
  2. Enable Rewards
  3. Open panel from BAT logo
  4. Select "Unverified"
  5. Follow prompts and verify with custodian

Confirmed able to verify with Uphold from panel:

Example Example Example
b c d
Scenario 3 - Verify from brave://rewards after getting naturally disconnected - PASSED
  1. Follow steps from scenario 1
  2. Navigate to Uphold site and revoke integration for Brave Browser
  3. Navigate back to brave://rewards and refresh if necessary to see the "Logged out" status
  4. Click on "Logged out" and select "Login to your Uphold account"
  5. Confirm able to reauthorize
Example Example Example Example
3 4 5a 5b

Repeat steps 1-5, but in step 4 click on "Log in to Uphold to see your balance" blue box

Example Example Example Example
2a 3 5a 5b
Scenario 4 - Verify from rewards panel after getting naturally disconnected - PASSED
  1. Follow steps from scenario 2
  2. Navigate to Uphold site and revoke integration for Brave Browser
  3. Open the panel to see the "Logged out" status
  4. Click on "Logged out" and select "Login to your Uphold account"
  5. Confirm able to reauthorize
Example Example Example Example
a b c d

Repeat steps 1-5, but in step 4 click on "Log in to Uphold to see your balance" blue box from panel

Example Example Example Example
a b c d

Repeat steps 1-5, but in step 4 click on "Reconnect" button from notification in panel

Example Example Example Example
a b c d
Gemini - PASSED
Scenario 1 - Verify from brave://rewards - PASSED
  1. Clean profile, staging env
  2. Enable Rewards
  3. Navigate to brave://rewards
  4. Select "Unverified"
  5. Follow prompts and verify with custodian

Confirmed able to verify with Gemini from brave://rewards page:

Example Example Example
a b c
Scenario 2 - Verify from rewards panel - PASSED
  1. Clean profile, staging env
  2. Enable Rewards
  3. Open panel from BAT logo
  4. Select "Unverified"
  5. Follow prompts and verify with custodian

Confirmed able to verify with Gemini from panel:

Example Example
a b
Scenario 3 - Verify from brave://rewards after getting naturally disconnected - PASSED
  1. Follow steps from scenario 1
  2. Navigate to Gemini site and revoke integration for Brave Browser
  3. Navigate back to brave://rewards and refresh if necessary to see the "Logged out" status (due to timing with Gemini, may have to wait up to 10 min)
  4. Click on "Logged out" and select "Login to your Gemini account"
  5. Confirm able to reauthorize
Example Example Example Example
a b c d

Repeat steps 1-5, but in step 4 click on "Log in to Gemini to see your balance" blue box

Example Example Example
a b c
Scenario 4 - Verify from rewards panel after getting naturally disconnected - PASSED
  1. Follow steps from scenario 2
  2. Navigate to Gemini site and revoke integration for Brave Browser
  3. Open the panel to see the "Logged out" status (may have to wait up to 10 min to see this due to timing with Gemini)
  4. Click on "Logged out" and select "Login to your Gemini account"
  5. Confirm able to reauthorize
Example Example Example Example
a b c d

Repeat steps 1-5, but in step 4 click on "Log in to Gemini to see your balance" blue box from panel

Example Example Example Example
a b c d

Repeat steps 1-5, but in step 4 click on "Reconnect" button from notification in panel

Example Example Example
a b c
bitFlyer - PASSED

Pre-req: Have region set to Japan

Scenario 1 - Verify from brave://rewards - PASSED
  1. Clean profile, staging env
  2. Enable Rewards
  3. Navigate to brave://rewards
  4. Select "Unverified"
  5. Follow prompts and verify with custodian

Confirmed able to verify with bitFlyer from brave://rewards page:

Example Example Example
a b c

Repeat steps 1-5 but select "Verify Brave Rewards" from brave://rewards onboarding:

Example Example Example
a b c
Scenario 2 - Verify from rewards panel - PASSED
  1. Clean profile, staging env
  2. Enable Rewards
  3. Open panel from BAT logo
  4. Select "Unverified"
  5. Follow prompts and verify with custodian

Confirmed able to verify with bitFlyer from panel:

Example Example
a b

Repeat steps 1-5 but select "Verify Brave Rewards" from panel onboarding:

Example Example
a b
Scenario 3 - Verify from brave://rewards after getting naturally disconnected - PASSED
  1. Follow steps from scenario 1
  2. Wait at least 7 minutes, then attempt to tip a bitFlyer verified creator
  3. Confirm you see "Logged out" status
  4. Click on "Logged out" and select "Login to your bitFlyer account"
  5. Confirm able to reauthorize
Example Example Example Example
a b c d

Repeat steps 1-5, but in step 4 click on "Log in to bitFlyer to see your balance" blue box

Example Example Example
a b c
Scenario 4 - Verify from rewards panel after getting naturally disconnected - PASSED
  1. Follow steps from scenario 2
  2. Wait at least 7 minutes, then attempt to tip a bitFlyer verified creator
  3. Confirm you see "Logged out" status
  4. Click on "Logged out" and select "Login to your bitFlyer account"
  5. Confirm able to reauthorize
Example Example Example Example
a b c d

Repeat steps 1-5, but in step 4 click on "Log in to bitFlyer to see your balance" blue box from panel

Example Example Example Example
a b c d

Repeat steps 1-5, but in step 4 click on "Reconnect" button from notification in panel

Example Example Example
a b c

@LaurenWags LaurenWags mentioned this issue Jul 18, 2022
Closed
@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 18, 2022
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 26, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Jul 26, 2022 •
edited
Loading

Verification PASSED on Samsung Galaxy S21 using

Brave	1.42.65 Chromium: 103.0.5060.114 (Official Build) beta (64-bit) 
Revision	a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS	Android 12; Build/SP1A.210812.016
Uphold - PASSED
Scenario 1 - Verify from brave://rewards - PASSED
  1. Clean profile, staging env
  2. Enable Rewards
  3. Navigate to brave://rewards
  4. Select "Unverified"
  5. Follow prompts and verify with custodian

Confirmed able to verify with Uphold from brave://rewards page:

1 2 3
screenshot-1658869971881 screenshot-1658869795030 screenshot-1658869857486
Scenario 2 - Verify from rewards panel - PASSED
  1. Clean profile, staging env
  2. Enable Rewards
  3. Open panel from BAT logo
  4. Select "Unverified"
  5. Follow prompts and verify with custodian

Confirmed able to verify with Uphold from panel:

1 2 3
screenshot-1658869932060 screenshot-1658869795030 screenshot-1658869857486
Scenario 3 - Verify from brave://rewards after getting naturally disconnected - PASSED
  1. Follow steps from scenario 1
  2. Navigate to Uphold site and revoke integration for Brave Browser
  3. Navigate back to brave://rewards and refresh if necessary to see the "Logged out" status
  4. Click on "Logged out" and select "Login to your Uphold account"
  5. Confirm able to reauthorize

Repeat steps 1-5, but in step 4 click on "Log in to Uphold to see your balance" blue box

1 2
screenshot-1658870050353 screenshot-1658870235439
Scenario 4 - Verify from rewards panel after getting naturally disconnected - FAILED
  1. Follow steps from scenario 2
  2. Navigate to Uphold site and revoke integration for Brave Browser
  3. Open the panel to see the "Logged out" status
  4. Click on "Logged out" and select "Login to your Uphold account"
  5. Confirm able to reauthorize

Repeat steps 1-5, but in step 4 click on "Log in to Uphold to see your balance" blue box from panel - FAILED

Repeat steps 1-5, but in step 4 click on "Reconnect" button from notification in panel - FAILED

1 2
screenshot-1658870085931 screenshot-1658870235439
Gemini - PASSED
Scenario 1 - Verify from brave://rewards - PASSED
  1. Clean profile, staging env
  2. Enable Rewards
  3. Navigate to brave://rewards
  4. Select "Unverified"
  5. Follow prompts and verify with custodian

Confirmed able to verify with Gemini from brave://rewards page:

1 2
screenshot-1658872996761 screenshot-1658873165017
Scenario 2 - Verify from rewards panel - PASSED
  1. Clean profile, staging env
  2. Enable Rewards
  3. Open panel from BAT logo
  4. Select "Unverified"
  5. Follow prompts and verify with custodian

Confirmed able to verify with Gemini from panel:

1 2
screenshot-1658872978206 screenshot-1658873165017
Scenario 3 - Verify from brave://rewards after getting naturally disconnected - PASSED
  1. Follow steps from scenario 1
  2. Navigate to Gemini site and revoke integration for Brave Browser
  3. Navigate back to brave://rewards and refresh if necessary to see the "Logged out" status (due to timing with Gemini, may have to wait up to 10 min)
  4. Click on "Logged out" and select "Login to your Gemini account"
  5. Confirm able to reauthorize

Repeat steps 1-5, but in step 4 click on "Log in to Gemini to see your balance" blue box

1 2 3
screenshot-1658873450882 screenshot-1658873463766 screenshot-1658873759096
Scenario 4 - Verify from rewards panel after getting naturally disconnected - FAILED
  1. Follow steps from scenario 2
  2. Navigate to Gemini site and revoke integration for Brave Browser
  3. Open the panel to see the "Logged out" status (may have to wait up to 10 min to see this due to timing with Gemini)
  4. Click on "Logged out" and select "Login to your Gemini account"
  5. Confirm able to reauthorize

Repeat steps 1-5, but in step 4 click on "Log in to Gemini to see your balance" blue box from panel - FAILED

Repeat steps 1-5, but in step 4 click on "Reconnect" button from notification in panel - FAILED

1 2
screenshot-1658873475588 screenshot-1658873463766
bitFlyer - PASSED

Pre-req: Have region set to Japan

Scenario 1 - Verify from brave://rewards - PASSED
  1. Clean profile, staging env
  2. Enable Rewards
  3. Navigate to brave://rewards
  4. Select "Unverified"
  5. Follow prompts and verify with custodian

PASS - Confirmed able to verify with bitFlyer from brave://rewards page:

PASS - Repeat steps 1-5 but select "Verify Brave Rewards" from brave://rewards onboarding:

1 2
screenshot-1658949396563 screenshot-1658949420492
Scenario 2 - Verify from rewards panel - PASSED
  1. Clean profile, staging env
  2. Enable Rewards
  3. Open panel from BAT logo
  4. Select "Unverified"
  5. Follow prompts and verify with custodian

PASS - Confirmed able to verify with bitFlyer from panel:

PASS - Repeat steps 1-5 but select "Verify Brave Rewards" from panel onboarding:

1 2
screenshot-1658949384658 screenshot-1658949420492
Scenario 3 - Verify from brave://rewards after getting naturally disconnected - PASSED
  1. Follow steps from scenario 1
  2. Wait at least 7 minutes, then attempt to tip a bitFlyer verified creator
  3. Confirm you see "Logged out" status
  4. Click on "Logged out" and select "Login to your bitFlyer account"
  5. Confirm able to reauthorize

PASSED - Repeat steps 1-5, but in step 4 click on "Log in to bitFlyer to see your balance" blue box

1 2 3
screenshot-1658949867291 screenshot-1658949971987 screenshot-1658949396563
Scenario 4 - Verify from rewards panel after getting naturally disconnected - PASSED
  1. Follow steps from scenario 2
  2. Wait at least 7 minutes, then attempt to tip a bitFlyer verified creator
  3. Confirm you see "Logged out" status
  4. Click on "Logged out" and select "Login to your bitFlyer account"
  5. Confirm able to reauthorize

FAILED - Repeat steps 1-5, but in step 4 click on "Log in to bitFlyer to see your balance" blue box from panel

FAILED - Repeat steps 1-5, but in step 4 click on "Reconnect" button from notification in panel

1 2
screenshot-1658949853806 screenshot-1658956970832

@Uni-verse
Copy link
Contributor

Uni-verse commented Jul 27, 2022 •
edited
Loading

Verification PASSED on Samsung Tab S7 using

Brave	1.42.80 Chromium: 104.0.5112.57 (Official Build) (64-bit) 
Revision	212fd173a0da1e0a024f328295bb56a2529190bb-refs/branch-heads/5112@{#1042}
OS	Android 12; Build/SP1A.210812.016
  • Performed spot checks on Android ARM Tablet for Uphold, Gemini and Bitflyer.
  • Able to verify wallet by logging into Gemini, Uphold and Bitflyer accounts.
  • Able to disconnect naturally and re-connect from the rewards page.

@Uni-verse Uni-verse added QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 27, 2022
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 28, 2022 •
edited
Loading

Verification PASSED on


Brave | 1.42.82 Chromium: 104.0.5112.69 (Official Build) (64-bit)
-- | --
Revision | 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS | Windows 10 Version 21H2 (Build 19044.1826)
Uphold - PASSED
Scenario 1 - Verify from brave://rewards - PASSED
  1. Clean profile, staging env
  2. Enable Rewards
  3. Navigate to brave://rewards
  4. Select "Unverified"
  5. Follow prompts and verify with custodian

Confirmed able to verify with Uphold from brave://rewards page:

1 2 3
image image image
Scenario 2 - Verify from rewards panel - PASSED
  1. Clean profile, staging env
  2. Enable Rewards
  3. Open panel from BAT logo
  4. Select "Unverified"
  5. Follow prompts and verify with custodian

Confirmed able to verify with Uphold from panel:

1 2 3
image image image
Scenario 3 - Verify from brave://rewards after getting naturally disconnected - PASSED
  1. Follow steps from scenario 1
  2. Navigate to Uphold site and revoke integration for Brave Browser
  3. Navigate back to brave://rewards and refresh if necessary to see the "Logged out" status
  4. Click on "Logged out" and select "Login to your Uphold account"
  5. Confirm able to reauthorize

Repeat steps 1-5, but in step 4 click on "Log in to Uphold to see your balance" blue box

Example Example Example Example
image image image image
Scenario 4 - Verify from rewards panel after getting naturally disconnected -
  1. Follow steps from scenario 2
  2. Navigate to Uphold site and revoke integration for Brave Browser
  3. Open the panel to see the "Logged out" status
  4. Click on "Logged out" and select "Login to your Uphold account"
  5. Confirm able to reauthorize

Repeat steps 1-5, but in step 4 click on "Log in to Uphold to see your balance" blue box from panel - FAILED

Repeat steps 1-5, but in step 4 click on "Reconnect" button from notification in panel - FAILED

Example Example Example Example
image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szilardszaloki szilardszaloki

Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.42.x - Release
Development

Successfully merging a pull request may close this issue.

Removes verify_url from ExternalWallet. brave/brave-core
5 participants
@szilardszaloki @Uni-verse @LaurenWags @GeetaSarvadnya @brave-builds