Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't update Brave on macOS if the new version is unsupported #22918

Closed
mherrmann opened this issue May 18, 2022 · 3 comments
Closed

Don't update Brave on macOS if the new version is unsupported #22918

mherrmann opened this issue May 18, 2022 · 3 comments
Assignees
@mherrmann
Labels
OS/Desktop OS/macOS OS/macOS-arm64 priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA Pass-macOS-arm64 QA/Yes release/blocking release-notes/include setup/installer
Milestone
1.39.x - Release

Comments

@mherrmann
Copy link

mherrmann commented May 18, 2022 •
edited
Loading

Description

At the moment, Brave's minimum supported macOS version is 10.11. Soon (M104), new versions of Chromium will drop support for macOS 10.11 and 10.12. This means that also we will drop support for these versions.

When this happened the last time, users on the previously highest macOS version received a new version of Brave that was incompatible with their system. The goal of this issue is to avoid this this time.

The solution is use Sparkle's minimumSystemVersion attribute to specify the minimum macOS version our updates require. We want to set this attribute on all our new versions. It should be automatically computed from Chromium's minimum declared macOS version.

Test Plan

1. Test that macOS updates still work

The existing update functionality (in the background and on-demand via brave://settings/help) should not be affected on supported macOS versions. See for example the section "Test Plan" in brave/brave-core#12335.

2. Test that newly unsupported macOS versions don't receive the update

Once Brave is based on Chromium 104+, download an old version of Brave on macOS 10.11 or 10.12. Go to brave://settings/help. If you do receive a new version via auto-updates this way, make sure that Brave can still be launched after. Expect the version you have received to be lower than the first version of Brave that is based on Chromium 104+.
@mherrmann mherrmann self-assigned this May 18, 2022
@rebron rebron added setup/installer QA/Yes priority/P2 A bad problem. We might uplift this to the next planned release. labels May 18, 2022
@mherrmann mherrmann mentioned this issue May 18, 2022
Closed
25 tasks
@mherrmann mherrmann added this to the 1.39.x - Release milestone May 21, 2022
@LaurenWags
Copy link
Member

LaurenWags commented May 23, 2022 •
edited
Loading

Verified using macOS 12.3.1 Monterey arm64

Brave	1.39.111 Chromium: 102.0.5005.61 (Official Build) (arm64) 
Revision	0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS	macOS Version 12.3.1 (Build 21E258)

Confirmed background updates worked as expected

  • Installed 1.38.119 Chromium: 101.0.4951.67 (Official Build) (arm64)
  • Closed browser and advanced computer clock 3 hours
  • Launched using test channel for updates
  • Observed the below in logs:
[61906:259:0523/153810.122931:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[61906:259:0523/153810.123379:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:20:48 +0000, Version: 1.39.111.0)
[61906:259:0523/153810.138067:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:20:48 +0000, Version: 1.39.111.0)
[61906:259:0523/153813.422135:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:20:48 +0000, Version: 1.39.111.0)
  • Never opened brave://settings/help
  • Relaunched browser
  • Confirmed expected version was shown on brave://version: 1.39.111 Chromium: 102.0.5005.61 (Official Build) (arm64)

Confirmed on demand updates worked as expected

  • Installed 1.38.119 Chromium: 101.0.4951.67 (Official Build) (arm64)
  • Closed browser
  • Launched using test channel for updates
  • Visited brave://settings/help, saw update downloading
  • Observed the below in logs:
[62123:259:0523/094411.267656:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[62123:259:0523/094411.268128:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:20:48 +0000, Version: 1.39.111.0)
[62123:259:0523/094411.268645:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:20:48 +0000, Version: 1.39.111.0)
[62123:259:0523/094414.756532:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:20:48 +0000, Version: 1.39.111.0)
[62123:259:0523/094436.684480:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:20:48 +0000, Version: 1.39.111.0)
  • Clicked "Relaunch" button
  • Confirmed expected version was shown on brave://settings/help 1.39.111 Chromium: 102.0.5005.61 (Official Build) (arm64)

Verified using macOS 12.3.1 Monterey x64

Brave | 1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64)
-- | --
Revision | 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS | macOS Version 12.3.1 (Build 21E258)

Confirmed background updates worked as expected

  • Installed 1.38.119 Chromium: 101.0.4951.67 (Official Build) (x86_64)
  • Closed browser and advanced computer clock 3 hours
  • Launched using test channel for updates
  • Observed the below in logs:
[14712:259:0523/130729.449351:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[14712:259:0523/130729.449942:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[14712:259:0523/130729.450758:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[14712:259:0523/130734.360995:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[14712:259:0523/130803.458642:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[14712:259:0523/130827.743619:INFO:sparkle_glue.mm(420)] brave update: will install update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
  • Never opened brave://settings/help
  • Relaunched browser
  • Confirmed expected version was shown on brave://version: 1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64)

Confirmed on demand updates worked as expected

  • Installed 1.38.119 Chromium: 101.0.4951.67 (Official Build) (x86_64)
  • Closed browser
  • Launched using test channel for updates
  • Visited brave://settings/help, saw update downloading
  • Observed the below in logs:
[15140:259:0523/101333.897794:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[15140:259:0523/101333.898469:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[15140:259:0523/101333.899870:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[15140:259:0523/101338.643530:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[15140:259:0523/101410.396303:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[15140:259:0523/101415.876456:INFO:sparkle_glue.mm(420)] brave update: will install update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
  • Clicked "Relaunch" button
  • Confirmed expected version was shown on brave://settings/help 1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64)

Verified with macOS 11.6.5 Big Sur x64

Brave	1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64) 
Revision	0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS	macOS Version 11.6.5 (Build 20G527)

Confirmed background updates worked as expected

  • Installed 1.38.119 Chromium: 101.0.4951.67 (Official Build) (x86_64)
  • Closed browser and advanced computer clock 3 hours
  • Launched using test channel for updates
  • Observed the below in logs:
[2114:259:0523/133216.639357:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[2114:259:0523/133216.641018:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[2114:259:0523/133216.641708:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[2114:259:0523/133221.805406:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[2114:259:0523/133256.921970:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[2114:259:0523/133316.668212:INFO:sparkle_glue.mm(420)] brave update: will install update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
  • Never opened brave://settings/help
  • Relaunched browser
  • Confirmed expected version was shown on brave://version: 1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64)

Confirmed on demand updates worked as expected

  • Installed 1.38.119 Chromium: 101.0.4951.67 (Official Build) (x86_64)
  • Closed browser
  • Launched using test channel for updates
  • Visited brave://settings/help, saw update downloading
  • Observed the below in logs:
[2424:259:0523/103739.100616:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[2424:259:0523/103739.103737:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[2424:259:0523/103739.105006:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[2424:259:0523/103743.474593:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[2424:259:0523/103821.611927:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[2424:259:0523/103830.007631:INFO:sparkle_glue.mm(420)] brave update: will install update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
  • Clicked "Relaunch" button
  • Confirmed expected version was shown on brave://settings/help 1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64)

Verified with macOS 10.15.7 Catalina x64

Brave	1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64) 
Revision	0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS	macOS Version 10.15.7 (Build 19H1824)

Confirmed background updates worked as expected

  • Installed 1.38.119 Chromium: 101.0.4951.67 (Official Build) (x86_64)
  • Closed browser and advanced computer clock 3 hours
  • Launched using test channel for updates
  • Observed the below in logs:
[1334:775:0523/135036.812456:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[1334:775:0523/135036.813565:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[1334:775:0523/135036.814555:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[1334:775:0523/135042.299825:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[1334:775:0523/135121.849972:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[1334:775:0523/135127.795941:INFO:sparkle_glue.mm(420)] brave update: will install update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
  • Never opened brave://settings/help
  • Relaunched browser
  • Confirmed expected version was shown on brave://version: 1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64)

Confirmed on demand updates worked as expected

  • Installed 1.38.119 Chromium: 101.0.4951.67 (Official Build) (x86_64)
  • Closed browser
  • Launched using test channel for updates
  • Visited brave://settings/help, saw update downloading
  • Observed the below in logs:
[1990:775:0523/105701.404409:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[1990:775:0523/105701.407685:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[1990:775:0523/105701.409998:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[1990:775:0523/105707.763848:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[1990:775:0523/105759.220638:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[1990:775:0523/105856.172389:INFO:sparkle_glue.mm(420)] brave update: will install update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
  • Clicked "Relaunch" button
  • Confirmed expected version was shown on brave://settings/help 1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64)

Verified with macOS 10.14.6 Mojave x64

Brave	1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64) 
Revision	0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS	macOS Version 10.14.6 (Build 18G103)

Confirmed background updates worked as expected

  • Installed 1.38.119 Chromium: 101.0.4951.67 (Official Build) (x86_64)
  • Closed browser and advanced computer clock 3 hours
  • Launched using test channel for updates
  • Observed the below in logs:
[756:775:0523/113113.393502:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[756:775:0523/113113.395366:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[756:775:0523/113113.396235:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[756:775:0523/113120.925999:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[756:775:0523/113153.683204:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[756:775:0523/113200.756230:INFO:sparkle_glue.mm(420)] brave update: will install update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
  • Never opened brave://settings/help
  • Relaunched browser
  • Confirmed expected version was shown on brave://version: 1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64)

Confirmed on demand updates worked as expected

  • Installed 1.38.119 Chromium: 101.0.4951.67 (Official Build) (x86_64)
  • Closed browser
  • Launched using test channel for updates
  • Visited brave://settings/help, saw update downloading
  • Observed the below in logs:
[978:775:0523/085935.850023:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[978:775:0523/085935.853783:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[978:775:0523/085935.858188:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[978:775:0523/085943.770273:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[978:775:0523/090057.351725:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[978:775:0523/090609.253103:INFO:sparkle_glue.mm(420)] brave update: will install update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
  • Clicked "Relaunch" button
  • Confirmed expected version was shown on brave://settings/help 1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64)

Verified with macOS 10.13.6 High Sierra x64

Brave	1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64) 
Revision	0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS	macOS Version 10.13.6 (Build 17G66)

Confirmed background updates worked as expected

  • Installed 1.38.119 Chromium: 101.0.4951.67 (Official Build) (x86_64)
  • Closed browser and advanced computer clock 3 hours
  • Launched using test channel for updates
  • Observed the below in logs:
[707:775:0523/123316.620233:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[707:775:0523/123316.622825:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[707:775:0523/123316.623911:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[707:775:0523/123325.849927:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[707:775:0523/123403.456371:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[707:775:0523/123415.117365:INFO:sparkle_glue.mm(420)] brave update: will install update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
  • Never opened brave://settings/help
  • Relaunched browser
  • Confirmed expected version was shown on brave://version: 1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64)

Confirmed on demand updates worked as expected

  • Installed 1.38.119 Chromium: 101.0.4951.67 (Official Build) (x86_64)
  • Closed browser
  • Launched using test channel for updates
  • Visited brave://settings/help, saw update downloading
  • Observed the below in logs:
[579:775:0523/094229.116889:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[579:775:0523/094229.121031:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[579:775:0523/094229.123466:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[579:775:0523/094240.342217:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[579:775:0523/094435.548408:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[579:775:0523/094444.693557:INFO:sparkle_glue.mm(420)] brave update: will install update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
  • Clicked "Relaunch" button
  • Confirmed expected version was shown on brave://settings/help 1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64)

@LaurenWags LaurenWags mentioned this issue May 23, 2022
Closed
@stephendonner
Copy link

stephendonner commented May 23, 2022 •
edited
Loading

Verified PASSED using the following builds/OSs:

Shared setup/steps

Background-update steps:

  1. download and install 1.38.119
  2. launch Brave using --enable-logging=stderr --vmodule=sparkle_glue=5,brave_relaunch_handler_mac=5 2>&1 --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  3. set system clock ahead 3+ hours
  4. relaunch Brave using --enable-logging=stderr --vmodule=sparkle_glue=5,brave_relaunch_handler_mac=5 2>&1 --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  5. check logs for update snippets
  6. restart Brave
  7. confirm version upgraded to Brave 1.39.111

On-demand update steps:

  1. download and install 1.38.119
  2. launch Brave using --enable-logging=stderr --vmodule=sparkle_glue=5,brave_relaunch_handler_mac=5 2>&1 --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  3. open brave://settings/help
  4. confirm it checks for and finds an update
  5. check logs for update snippets
  6. click to Relaunch Brave
  7. confirm version upgraded to Brave 1.39.111

macOS 11.6.6 Big Sur arm64

Brave 1.38.119 Chromium: 101.0.4951.67 (Official Build) (arm64)
Revision 8888ee7a24e2c36661ddb9536c35b7d4852a3a98-refs/branch-heads/4951@{#1230}
OS macOS Version 11.6.6 (Build 20G624)

Background update:

[3472:259:0523/185731.849085:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[3472:259:0523/185731.865925:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[3472:259:0523/185731.866477:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[3472:259:0523/185733.122455:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[3472:259:0523/185753.388648:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)

On-demand update:

[3108:259:0523/155017.598984:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[3108:259:0523/155017.599844:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[3108:259:0523/155017.600476:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[3108:259:0523/155018.822195:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[3108:259:0523/155038.272670:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[3108:259:0523/155054.957883:INFO:sparkle_glue.mm(420)] brave update: will install update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)

macOS 11.6.6 Big Sur x64

Brave 1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS macOS Version 11.6.6 (Build 20G624)

Background update:

[23847:259:0523/192459.655032:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[23847:259:0523/192459.656535:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[23847:259:0523/192459.658106:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[23847:259:0523/192531.971690:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[23847:259:0523/192612.534011:INFO:sparkle_glue.mm(420)] brave update: will install update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)

On-demand update:

[23588:259:0523/162029.786884:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[23588:259:0523/162029.788211:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[23588:259:0523/162029.790365:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[23588:259:0523/162104.742713:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[23588:259:0523/162116.248742:INFO:sparkle_glue.mm(420)] brave update: will install update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)

macOS 12.5 (public beta - 21G5027d) Monterey x64

Brave 1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS macOS Version 12.5 (Build 21G5027d)

Background update:

[14268:259:0523/195108.193196:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[14268:259:0523/195108.193980:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[14268:259:0523/195108.194833:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[14268:259:0523/195115.707324:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[14268:259:0523/195144.293632:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)

On-demand update:

[13933:259:0523/163432.776343:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[13933:259:0523/163432.777087:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[13933:259:0523/163432.777848:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[13933:259:0523/163438.800000:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[13933:259:0523/163515.569869:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 23, 2022
@kjozwiak
Copy link
Member

Verified PASSED on macOS 10.13.6 x64 High Sierra using the following build(s):

Brave | 1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64)
-- | --
Revision | 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS | macOS Version 10.13.6 (Build 17G14042)

Confirmed background updates worked as expected

  • Installed 1.38.119 Chromium: 101.0.4951.67
  • Closed browser and advanced computer clock 3 hours
  • Launched using test channel for updates
  • Observed the below in logs:
[838:775:0530/223350.435344:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[838:775:0530/223350.436561:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[838:775:0530/223350.535574:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[838:775:0530/223356.659980:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[838:775:0530/223438.817796:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[838:775:0530/223621.069794:INFO:sparkle_glue.mm(420)] brave update: will install update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
  • Never opened brave://settings/help
  • Relaunched browser
  • Confirmed expected version was shown on brave://version: 1.39.111 Chromium: 102.0.5005.61

Confirmed on demand updates worked as expected

  • Installed 1.38.119 Chromium: 101.0.4951.67
  • Closed browser
  • Launched using test channel for updates
  • Visited brave://settings/help, saw update downloading
  • Observed the below in logs:
[937:775:0530/223835.991171:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[937:775:0530/223835.992367:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[937:775:0530/223835.993347:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[937:775:0530/223842.056158:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[937:775:0530/223922.650211:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[937:775:0530/224003.150076:INFO:sparkle_glue.mm(420)] brave update: will install update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
  • Clicked "Relaunch" button
  • Confirmed expected version was shown on brave://settings/help 1.39.111 Chromium: 102.0.5005.61

Verification PASSED on macOS 10.12.6 x64 Sierra using the following build(s):

Brave | 1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64)
-- | --
Revision | 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS | macOS Version 10.12.6 (Build 16G2136)

Confirmed background updates worked as expected

  • Installed 1.38.119 Chromium: 101.0.4951.67
  • Closed browser and advanced computer clock 3 hours
  • Launched using test channel for updates
  • Observed the below in logs:
[599:775:0526/225217.637915:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[599:775:0526/225217.638845:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[599:775:0526/225217.639282:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[599:775:0526/225224.290877:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[599:775:0526/225303.292273:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
  • Never opened brave://settings/help
  • Relaunched browser
  • Confirmed expected version was shown on brave://version: 1.39.111 Chromium: 102.0.5005.61

Confirmed on demand updates worked as expected

  • Installed 1.38.119 Chromium: 101.0.4951.67
  • Closed browser
  • Launched using test channel for updates
  • Visited brave://settings/help, saw update downloading
  • Observed the below in logs:
[951:775:0523/225916.420865:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[951:775:0523/225916.421981:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[951:775:0523/225916.422871:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[951:775:0523/225921.856895:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[951:775:0523/230002.166350:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
  • Clicked "Relaunch" button
  • Confirmed expected version was shown on brave://settings/help 1.39.111 Chromium: 102.0.5005.61

Verified PASSED on OS X 10.11.6 x64 El Captain using the following build(s):

Brave | 1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64)
-- | --
Revision | 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS | OS X Version 10.11.6 (Build 15G22010)

Confirmed background updates worked as expected

  • Installed 1.38.119 Chromium: 101.0.4951.67
  • Closed browser and advanced computer clock 3 hours
  • Launched using test channel for updates
  • Observed the below in logs:
[815:1295:0527/230545.253800:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[815:1295:0527/230545.266169:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[815:1295:0527/230545.266749:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[815:1295:0527/230555.088861:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[815:1295:0527/230709.425404:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
  • Never opened brave://settings/help
  • Relaunched browser
  • Confirmed expected version was shown on brave://version: 1.39.111 Chromium: 102.0.5005.61

Confirmed on demand updates worked as expected

  • Installed 1.38.119 Chromium: 101.0.4951.67 (Official Build) (x86_64)
  • Closed browser
  • Launched using test channel for updates
  • Visited brave://settings/help, saw update downloading
  • Observed the below in logs:
[981:1295:0523/231118.971389:INFO:sparkle_glue.mm(367)] brave update: did finish loading appcast
[981:1295:0523/231118.972719:INFO:sparkle_glue.mm(373)] brave update: did find valid update with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[981:1295:0523/231118.973457:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[981:1295:0523/231125.056169:INFO:sparkle_glue.mm(394)] brave update: willDownloadUpdate with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
[981:1295:0523/231203.243679:INFO:sparkle_glue.mm(430)] brave update: will install update on quit with AppcastItem(Date: Sun, 22 May 2022 08:57:00 +0000, Version: 1.39.111.0)
  • Clicked "Relaunch" button
  • Confirmed expected version was shown on brave://settings/help `1.39.111 Chromium: 102.0.5005.61

avinassh pushed a commit to avinassh/brave-browser-hardening that referenced this issue May 29, 2022
Brave Browser 1.39.111
6b60f4b 
 - Added Solana support for account creation, sending SOL and sending SPL tokens with Brave Wallet. ([#22348](brave/brave-browser#22348))
 - Added the ability to buy with Ramp using Brave Wallet. ([#21639](brave/brave-browser#21639))
 - Added JSONSanitizer to API helper requests for Brave Wallet. ([#21831](brave/brave-browser#21831))
 - Added Dapp UI for requesting a public key and for decrypting ciphers using Brave Wallet. ([#21177](brave/brave-browser#21177))
 - Added web3_clientVersion support for Brave Wallet. ([#19278](brave/brave-browser#19278))
 - Added the ability to allow users to search sites for RSS feeds for Brave News. ([#21768](brave/brave-browser#21768))
 - Added support for blob partitioning. ([#21746](brave/brave-browser#21746))
 - Added minimum macOS version for Sparkle update process. ([#22918](brave/brave-browser#22918))
 - [Security] Blocked "window.ethereum" completely in third party iframes. ([#22686](brave/brave-browser#22686))
 - [Security] Updated Brave Wallet panel to prominently display eTLD+1 as reported on HackerOne by renekroka. ([#21787](brave/brave-browser#21787))
 - [Security] Fixed incorrect origin being displayed in Brave Wallet when a spend approval is pending. ([#19557](brave/brave-browser#19557))
 - Implemented eth_getEncryptionPublicKey for Brave Wallet. ([#19276](brave/brave-browser#19276))
 - Implemented account discovery when restoring Brave Wallet. ([#18104](brave/brave-browser#18104))
 - Updated Omaha installer version for Windows to v1.3.36.113. ([#22060](brave/brave-browser#22060))
 - Updated default IPFS configuration values. ([#22068](brave/brave-browser#22068))
 - Updated Gas Limit validation and error messaging for unapproved transactions with Brave Wallet. ([#21714](brave/brave-browser#21714))
 - Updated Brave Wallet to automatically add swap taker asset to the visible asset list. ([#21428](brave/brave-browser#21428))
 - Updated Brave Wallet portfolio network filter for multichain support. ([#20780](brave/brave-browser#20780))
 - Reduced adblock filter memory usage by optimizing unused regex rules. ([#21970](brave/brave-browser#21970))
 - Removed known Dialog Insight user tracking parameters from URLs. ([#22082](brave/brave-browser#22082))
 - Removed ability to swap ERC721 tokens with Brave Wallet. ([#21550](brave/brave-browser#21550))
 - Fixed crash which occurred when opening Brave Shields while using Google Meet. ([#22814](brave/brave-browser#22814))
 - Fixed inability to rename Solana account in Brave Wallet after it has been created. ([#22958](brave/brave-browser#22958))
 - Fixed incorrectly computed insufficient funds errors in Brave Wallet. ([#22877](brave/brave-browser#22877))
 - Fixed ERC20 and ERC721 transfers being incorrectly displayed as ETH transfers in the Brave Wallet transactions panel. ([#22044](brave/brave-browser#22044))
 - Fixed text alignment issues under the Brave Wallet "Recent transactions" panel when using long account names. ([#21216](brave/brave-browser#21216))
 - Fixed breakage in webpack build caused by OpenSSL 3.0. ([#22305](brave/brave-browser#22305))
 - Fixed two windows being opened on launch when the browser was installed without administrator privileges on Windows. ([#22179](brave/brave-browser#22179))
 - Upgraded Chromium to 102.0.5005.61. ([#22923](brave/brave-browser#22923)) ([Changelog for 102.0.5005.61](https://chromium.googlesource.com/chromium/src/+log/101.0.4951.67..102.0.5005.61?pretty=fuller&n=1000))
@mherrmann mherrmann mentioned this issue Jun 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mherrmann mherrmann

Labels
OS/Desktop OS/macOS OS/macOS-arm64 priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA Pass-macOS-arm64 QA/Yes release/blocking release-notes/include setup/installer
Projects
None yet
Milestone
1.39.x - Release
Development

Successfully merging a pull request may close this issue.

Save Chromium's mac_min_system_version to a file brave/brave-core
5 participants
@stephendonner @mherrmann @kjozwiak @rebron @LaurenWags