Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower values in IPFS Swarm.ConnMgr #22068

Closed
lidel opened this issue Apr 4, 2022 · 1 comment · Fixed by brave/brave-core#12910
Closed

Lower values in IPFS Swarm.ConnMgr #22068

lidel opened this issue Apr 4, 2022 · 1 comment · Fixed by brave/brave-core#12910
Assignees
@spylogsster
Labels
OS/Desktop QA Pass-macOS QA/Yes release-notes/include
Milestone
1.39.x - Release

Comments

@lidel
Copy link

lidel commented Apr 4, 2022

Brave should follow the suit and change the values to:

config.Swarm.ConnMgr.GracePeriod = "20s"
config.Swarm.ConnMgr.LowWater = 20
config.Swarm.ConnMgr.HighWater = 40

Rationale:

  • Connection Manager controls how many connections are kept around when idle.
  • Historically these values were high, but they no longer need to be (we have better DHT, QUIC etc).
  • Less connections means lower bandwidth and CPU usage when user is not actively browsing ipfs:// resources.
  • IPFS Desktop ships with less expensive values (fix: lowpower config in Swarm.ConnMgr ipfs/ipfs-desktop#2055)

cc @autonome @spylogsster
@spylogsster spylogsster self-assigned this Apr 6, 2022
@spylogsster spylogsster mentioned this issue Apr 6, 2022
Merged
25 tasks
@spylogsster spylogsster added this to the 1.39.x - Nightly milestone Apr 6, 2022
@stephendonner
Copy link

Verified PASSED using

Brave 1.39.51 Chromium: 100.0.4896.88 (Official Build) nightly (x86_64)
Revision 4450653bfa91182e85723d8f1dee64dd6ce40ed4-refs/branch-heads/4896@{#1086}
OS macOS Version 11.6.5 (Build 20G527)

Confirmed installation and basic smoketest of IPFS

Confirmed new values

Steps:

  1. installed 1.39.51
  2. loaded ipns://[docs.]ipfs.io
  3. clicked on Install a Brave local IPFS node
  4. checked various IPFS resources
example example example example example
Screen Shot 2022-04-12 at 3 43 26 PM Screen Shot 2022-04-12 at 3 44 11 PM Screen Shot 2022-04-12 at 3 44 21 PM Screen Shot 2022-04-12 at 3 44 26 PM Screen Shot 2022-04-12 at 3 48 23 PM

@LaurenWags LaurenWags mentioned this issue May 23, 2022
Closed
avinassh pushed a commit to avinassh/brave-browser-hardening that referenced this issue May 29, 2022
Brave Browser 1.39.111
6b60f4b 
 - Added Solana support for account creation, sending SOL and sending SPL tokens with Brave Wallet. ([#22348](brave/brave-browser#22348))
 - Added the ability to buy with Ramp using Brave Wallet. ([#21639](brave/brave-browser#21639))
 - Added JSONSanitizer to API helper requests for Brave Wallet. ([#21831](brave/brave-browser#21831))
 - Added Dapp UI for requesting a public key and for decrypting ciphers using Brave Wallet. ([#21177](brave/brave-browser#21177))
 - Added web3_clientVersion support for Brave Wallet. ([#19278](brave/brave-browser#19278))
 - Added the ability to allow users to search sites for RSS feeds for Brave News. ([#21768](brave/brave-browser#21768))
 - Added support for blob partitioning. ([#21746](brave/brave-browser#21746))
 - Added minimum macOS version for Sparkle update process. ([#22918](brave/brave-browser#22918))
 - [Security] Blocked "window.ethereum" completely in third party iframes. ([#22686](brave/brave-browser#22686))
 - [Security] Updated Brave Wallet panel to prominently display eTLD+1 as reported on HackerOne by renekroka. ([#21787](brave/brave-browser#21787))
 - [Security] Fixed incorrect origin being displayed in Brave Wallet when a spend approval is pending. ([#19557](brave/brave-browser#19557))
 - Implemented eth_getEncryptionPublicKey for Brave Wallet. ([#19276](brave/brave-browser#19276))
 - Implemented account discovery when restoring Brave Wallet. ([#18104](brave/brave-browser#18104))
 - Updated Omaha installer version for Windows to v1.3.36.113. ([#22060](brave/brave-browser#22060))
 - Updated default IPFS configuration values. ([#22068](brave/brave-browser#22068))
 - Updated Gas Limit validation and error messaging for unapproved transactions with Brave Wallet. ([#21714](brave/brave-browser#21714))
 - Updated Brave Wallet to automatically add swap taker asset to the visible asset list. ([#21428](brave/brave-browser#21428))
 - Updated Brave Wallet portfolio network filter for multichain support. ([#20780](brave/brave-browser#20780))
 - Reduced adblock filter memory usage by optimizing unused regex rules. ([#21970](brave/brave-browser#21970))
 - Removed known Dialog Insight user tracking parameters from URLs. ([#22082](brave/brave-browser#22082))
 - Removed ability to swap ERC721 tokens with Brave Wallet. ([#21550](brave/brave-browser#21550))
 - Fixed crash which occurred when opening Brave Shields while using Google Meet. ([#22814](brave/brave-browser#22814))
 - Fixed inability to rename Solana account in Brave Wallet after it has been created. ([#22958](brave/brave-browser#22958))
 - Fixed incorrectly computed insufficient funds errors in Brave Wallet. ([#22877](brave/brave-browser#22877))
 - Fixed ERC20 and ERC721 transfers being incorrectly displayed as ETH transfers in the Brave Wallet transactions panel. ([#22044](brave/brave-browser#22044))
 - Fixed text alignment issues under the Brave Wallet "Recent transactions" panel when using long account names. ([#21216](brave/brave-browser#21216))
 - Fixed breakage in webpack build caused by OpenSSL 3.0. ([#22305](brave/brave-browser#22305))
 - Fixed two windows being opened on launch when the browser was installed without administrator privileges on Windows. ([#22179](brave/brave-browser#22179))
 - Upgraded Chromium to 102.0.5005.61. ([#22923](brave/brave-browser#22923)) ([Changelog for 102.0.5005.61](https://chromium.googlesource.com/chromium/src/+log/101.0.4951.67..102.0.5005.61?pretty=fuller&n=1000))
@markg85 markg85 mentioned this issue Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
OS/Desktop QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Milestone
1.39.x - Release
Development

Successfully merging a pull request may close this issue.

Updated default ipfs config values brave/brave-core
3 participants
@lidel @stephendonner @spylogsster